linux-kernel - Re: [patch V3 06/12] rseq: Implement sys_rseq_slice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <875xbusruq.ffs@tglx>
Date: Fri, 31 Oct 2025 22:07:09 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, LKML
 <linux-kernel@...r.kernel.org>
Cc: Peter Zijlstra <peterz@...radead.org>, Arnd Bergmann <arnd@...db.de>,
 linux-arch@...r.kernel.org, "Paul E. McKenney" <paulmck@...nel.org>, Boqun
 Feng <boqun.feng@...il.com>, Jonathan Corbet <corbet@....net>, Prakash
 Sangappa <prakash.sangappa@...cle.com>, Madadi Vineeth Reddy
 <vineethr@...ux.ibm.com>, K Prateek Nayak <kprateek.nayak@....com>, Steven
 Rostedt <rostedt@...dmis.org>, Sebastian Andrzej Siewior
 <bigeasy@...utronix.de>
Subject: Re: [patch V3 06/12] rseq: Implement sys_rseq_slice_yield()

On Fri, Oct 31 2025 at 15:46, Mathieu Desnoyers wrote:

> On 2025-10-29 09:22, Thomas Gleixner wrote:
>>   
>> +/**
>> + * sys_rseq_slice_yield - yield the current processor if a task granted
>> + *			  with a time slice extension is done with the
>> + *			  critical work before being forced out.
>> + *
>> + * On entry from user space, syscall_entry_work() ensures that NEED_RESCHED is
>> + * set if the task was granted a slice extension before arriving here.
>> + *
>> + * Return: 1 if the task successfully yielded the CPU within the granted slice.
>> + *         0 if the slice extension was either never granted or was revoked by
>> + *	     going over the granted extension or being scheduled out earlier
>
> I notice the presence of tabs in those comments. You will likely want
> to convert those to spaces.

And why so? It's perfectly formatted and there is ZERO reason to use
spaces in comments when you want to have aligned formatting.

Thanks,

        tglx