linux-kernel - Re: [tip:irq/drivers 22/22] drivers/irqchip/irq-sifive-plic.c:590:55: sparse: sparse: incorrect type in argument 1 (different address spaces)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87346ysqnv.ffs@tglx>
Date: Fri, 31 Oct 2025 22:32:52 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Charles Mirabile <cmirabil@...hat.com>, lkp@...el.com
Cc: cmirabil@...hat.com, linux-kernel@...r.kernel.org, lzampier@...hat.com,
 oe-kbuild-all@...ts.linux.dev, x86@...nel.org
Subject: Re: [tip:irq/drivers 22/22]
 drivers/irqchip/irq-sifive-plic.c:590:55: sparse: sparse: incorrect type
 in argument 1 (different address spaces)

On Mon, Oct 27 2025 at 13:47, Charles Mirabile wrote:
> diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
> index 9c4af7d58846..fbf7378899d3 100644
> --- a/drivers/irqchip/irq-sifive-plic.c
> +++ b/drivers/irqchip/irq-sifive-plic.c
> @@ -590,12 +590,12 @@ static int plic_probe(struct fwnode_handle *fwnode)
>  		if (parent_hwirq != RV_IRQ_EXT) {
>  			/* Disable S-mode enable bits if running in M-mode. */
>  			if (IS_ENABLED(CONFIG_RISCV_M_MODE)) {
> -				void __iomem *enable_base = priv->regs +
> +				u32 __iomem *enable_base = priv->regs +
>  					CONTEXT_ENABLE_BASE +
>  					i * CONTEXT_ENABLE_SIZE;
>  
> -				for (hwirq = 1; hwirq <= nr_irqs; hwirq++)
> -					__plic_toggle(enable_base, hwirq, 0);
> +				for (int j = 0; j <= nr_irqs / 32; j++)
> +					writel(0, enable_base + j);
>  			}
>  			continue;
>  		}

Care to send a proper patch for that?