linux-kernel - Re: [RFC PATCH 05/21] vfio/pci: Register VFIO live update file handler to Live Update Orchestrator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALzav=f9tjgyF7TBsfjCpmvRezkkgfQY-OXwj+TaebjeffK-0A@mail.gmail.com>
Date: Fri, 31 Oct 2025 15:28:27 -0700
From: David Matlack <dmatlack@...gle.com>
To: Vipin Sharma <vipinsh@...gle.com>
Cc: bhelgaas@...gle.com, pasha.tatashin@...een.com, jgg@...pe.ca, 
	graf@...zon.com, pratyush@...nel.org, gregkh@...uxfoundation.org, 
	chrisl@...nel.org, rppt@...nel.org, skhawaja@...gle.com, parav@...dia.com, 
	saeedm@...dia.com, kevin.tian@...el.com, jrhilke@...gle.com, david@...hat.com, 
	jgowans@...zon.com, dwmw2@...radead.org, epetron@...zon.de, 
	junaids@...gle.com, linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org, 
	kvm@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	Alex Williamson <alex@...zbot.org>
Subject: Re: [RFC PATCH 05/21] vfio/pci: Register VFIO live update file
 handler to Live Update Orchestrator

On Fri, Oct 17, 2025 at 5:07 PM Vipin Sharma <vipinsh@...gle.com> wrote:
> +static const struct liveupdate_file_ops vfio_pci_luo_fops = {
> +       .retrieve = vfio_pci_liveupdate_retrieve,
> +       .can_preserve = vfio_pci_liveupdate_can_preserve,
> +       .owner = THIS_MODULE,
> +};
> +
> +static struct liveupdate_file_handler vfio_pci_luo_handler = {
> +       .ops = &vfio_pci_luo_fops,
> +       .compatible = "vfio-v1",
> +};
> +
> +void __init vfio_pci_liveupdate_init(void)
> +{
> +       int err = liveupdate_register_file_handler(&vfio_pci_luo_handler);
> +
> +       if (err)
> +               pr_err("VFIO PCI liveupdate file handler register failed, error %d.\n", err);
> +}

Alex and Jason, should this go in the top-level VFIO directory? And
then have all the preservation logic go through vfio_device_ops? That
would make Live Update support for VFIO cdev files extensible to other
drivers in the future.