linux-kernel - Re: [PATCH net-next v2 1/2] net: mana: Refactor GF stats to use global mana

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251031160632.41c1167f@kernel.org>
Date: Fri, 31 Oct 2025 16:06:32 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Erni Sri Satya Vennela <ernis@...ux.microsoft.com>
Cc: kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
 decui@...rosoft.com, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, longli@...rosoft.com,
 kotaranov@...rosoft.com, horms@...nel.org,
 shradhagupta@...ux.microsoft.com, ssengar@...ux.microsoft.com,
 dipayanroy@...ux.microsoft.com, shirazsaleem@...rosoft.com,
 rosenp@...il.com, linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/2] net: mana: Refactor GF stats to use
 global mana_context

On Wed, 29 Oct 2025 03:37:51 -0700 Erni Sri Satya Vennela wrote:
> Refactor mana_query_gf_stats() to use mana_context instead of per-port,
> enabling single query for all VFs.

What does "single query for all VFs" mean?
All types? All within the host?

Coincidentally I don't know what HC and GF stand for.
Please explain things in more detail, all atypical acronyms 
(for *Linux* networking).

> Isolate hardware counter stats by introducing mana_ethtool_hc_stats
> in mana_context and update the code to ensure all stats are properly
> reported via ethtool -S <interface>, maintaining consistency with
> previous behavior.

> -void mana_query_gf_stats(struct mana_port_context *apc)
> +void mana_query_gf_stats(struct mana_context *ac)
>  {
>  	struct mana_query_gf_stat_resp resp = {};
>  	struct mana_query_gf_stat_req req = {};
> -	struct net_device *ndev = apc->ndev;
> +	struct gdma_context *gc = ac->gdma_dev->gdma_context;

reverse xmas tree, please

> +	struct device *dev = gc->dev;
>  	int err;