linux-kernel - Re: [PATCH v3 11/14] serial: sc16is7xx: use KBUILD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025103109-astronaut-oblivious-ad13@gregkh>
Date: Fri, 31 Oct 2025 08:06:21 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Hugo Villeneuve <hugo@...ovil.com>
Cc: Andy Shevchenko <andriy.shevchenko@...el.com>, jirislaby@...nel.org,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	Hugo Villeneuve <hvilleneuve@...onoff.com>
Subject: Re: [PATCH v3 11/14] serial: sc16is7xx: use KBUILD_MODNAME

On Thu, Oct 30, 2025 at 04:01:42PM -0400, Hugo Villeneuve wrote:
> On Thu, 30 Oct 2025 11:35:00 +0100
> Andy Shevchenko <andriy.shevchenko@...el.com> wrote:
> 
> > On Mon, Oct 27, 2025 at 10:29:53AM -0400, Hugo Villeneuve wrote:
> > > 
> > > There is no need to redefine the driver name. Use KBUILD_MODNAME and get
> > > rid of DRV_NAME altogether.
> > 
> > Actually I am slightly against this change. The modname (and hence modalias)
> > are parts of an ABI (visible via sysfs). Changing the module name (file name
> > in this case) may inadvertently break this. Yes, it most likely not critical
> > in this case, but should be taken into account.
> 
> Hi Andy,
> thank you for pointing that out. It didn't occur to me that this could
> impact the sysfs ABI.

This should not be an issue, the device name will not have changed, and
that's the normal sysfs path for things.  The module/driver name can
always change, this isn't a real problem.

thanks,

greg k-h