linux-kernel - Re: [PATCH v2 1/2] dt-bindings: hwmon: Add support for ST TSC1641 power monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35d41d46-5bc8-43af-a84d-6b118fff08e0@kernel.org>
Date: Fri, 31 Oct 2025 08:57:47 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Igor Reznichenko <igor@...nichenko.net>, robh@...nel.org,
 linux@...ck-us.net
Cc: conor+dt@...nel.org, corbet@....net, david.hunter.linux@...il.com,
 devicetree@...r.kernel.org, krzk+dt@...nel.org, linux-doc@...r.kernel.org,
 linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
 skhan@...uxfoundation.org
Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: Add support for ST TSC1641
 power monitor

On 31/10/2025 05:40, Igor Reznichenko wrote:
>> On 10/28/25 08:17, Igor Reznichenko wrote:
>>> Understood. The bit in question controls the alert pin polarity on the device side,
>>> independent of whether the pin is used as interrupt or not. I'll drop the property
>>> for now and revisit if there's a board that actually uses an inverter or needs to
>>> program the bit explicitly.
>>>
>>
>> This is kind of unusual. The requirement used to be that devicetree properties
>> shall be complete. "Only if there is a known use case" is a significant policy
>> change. Has the policy changed recently ?
>>
>> Thanks,
>> Guenter
> 
> Rob, following up on Guenter's question above.
> I'm not sure whether it's better to drop the property as discussed earlier or keep
> it for binding completeness. 
> Could you clarify what approach is preferred?

Don't you have there possibility of interrupt (not only SMBus Alert)? At
least this is what I understood from previous talks.

Best regards,
Krzysztof