linux-kernel - Re: [PATCH v2 3/5] regcache: flat: Remove unneeded check and error message for -ENOMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQRtYXcltiJwa3lB@smile.fi.intel.com>
Date: Fri, 31 Oct 2025 10:03:45 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Sander Vanheule <sander@...nheule.net>
Cc: Mark Brown <broonie@...nel.org>,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Danilo Krummrich <dakr@...nel.org>
Subject: Re: [PATCH v2 3/5] regcache: flat: Remove unneeded check and error
 message for -ENOMEM

On Thu, Oct 30, 2025 at 09:18:11PM +0100, Sander Vanheule wrote:
> On Thu, 2025-10-30 at 18:37 +0100, Andy Shevchenko wrote:
> > There is a convention in the kernel to avoid error messages
> > in the cases of -ENOMEM errors. Besides that, the idea behind
> > using struct_size() and other macros from overflow.h is
> > to saturate the size that the following allocation call will
> > definitely fail, hence the check and the error messaging added
> > in regcache_flat_init() are redundant. Remove them.

> Makes sense, although I couldn't find the failure path myself in the code (it's probably
> too deep down in the memory management code). But I see now there are unit tests that
> check allocation failure for overflowed sizes.
> 
> FWIW
> 
> Acked-by: Sander Vanheule <sander@...nheule.net>

Thanks for looking into this.

-- 
With Best Regards,
Andy Shevchenko