linux-kernel - Re: [PATCH v2 3/3] firmware: stratix10-svc: add the compatible value for Agilex5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <858557af-f421-471d-a9e3-b7b44e768af8@altera.com>
Date: Fri, 31 Oct 2025 08:12:54 +0000
From: "Romli, Khairul Anuar" <khairul.anuar.romli@...era.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Dinh Nguyen <dinguyen@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	"Rao, Mahesh" <mahesh.rao@...era.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] firmware: stratix10-svc: add the compatible value
 for Agilex5

On 31/10/2025 4:00 pm, Krzysztof Kozlowski wrote:
> On 31/10/2025 00:08, Romli, Khairul Anuar wrote:
>> On 31/10/2025 12:33 am, Krzysztof Kozlowski wrote:
>>>> I was excluding the iommu in the current patch series, not that I meant
>>>> there is no iommu. It was meant for the future patches that will include
>>>
>>> Read your bindings again. They clearly do not list IOMMU, meaning there
>>> is no IOMMU.
>>>
>>> Best regards,
>>> Krzysztof
>>
>> I will add that in the next revision also after going through
>> https://www.kernel.org/doc/Documentation/devicetree/bindings/writing-bindings.rst
>>
>> One question, if the property only meant for a specific compatible, do
>> you accept the logical "if" statement to ensure that the property only
>> for specific device but not others?
>
> Yes, see example-schema how to do it (and property is always described
> in top-level).
>
> Best regards,
> Krzysztof

Great, I will see the example-schema and also go through the already
implemented bindings that has the relevant changes.

Thanks.

Best Regards,
Khairul