linux-kernel - Re: [PATCH v7 5/9] platform/x86: asus-wmi: Add support for multiple kbd led handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39n24387-0o0n-50p8-s2rn-9qoqs6sq8336@xreary.bet>
Date: Fri, 31 Oct 2025 09:26:56 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Antheas Kapenekakis <lkml@...heas.dev>
cc: kernel test robot <lkp@...el.com>, platform-driver-x86@...r.kernel.org, 
    linux-input@...r.kernel.org, oe-kbuild-all@...ts.linux.dev, 
    linux-kernel@...r.kernel.org, Benjamin Tissoires <bentiss@...nel.org>, 
    Corentin Chary <corentin.chary@...il.com>, 
    "Luke D . Jones" <luke@...nes.dev>, Hans de Goede <hdegoede@...hat.com>, 
    Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, 
    Denis Benato <benato.denis96@...il.com>
Subject: Re: [PATCH v7 5/9] platform/x86: asus-wmi: Add support for multiple
 kbd led handlers

On Thu, 23 Oct 2025, Antheas Kapenekakis wrote:

> >   1589
> >   1590  static void kbd_led_update_all(struct work_struct *work)
> >   1591  {
> >   1592          enum led_brightness value;
> >   1593          struct asus_wmi *asus;
> >   1594          bool registered, notify;
> >   1595          int ret;
>                               /\ value should have been an int and
> placed here. It can take the value -1 hence the check

Thanks, that needs to be fixed before the final merge.

> Are there any other comments on the series?
> 
> The only issue I am aware of is that Denis identified a bug in asusd
> (asusctl userspace program daemon) in certain Asus G14/G16 laptops
> that cause laptop keys to become sticky, I have had users also report
> that bug in previous versions of the series. WIthout asusd running,
> keyboards work fine incl. with brightness control (did not work
> before). Given it will take two months for this to reach mainline, I
> think it is a fair amount of time to address the bug.

One thing that is not clear to me about this -- is this causing a visible 
user-space behavior regression before vs. after the patchset with asusctl?

If so, I am afraid this needs to be root-caused and fixed before the set 
can be considered for inclusion.

Thanks,

-- 
Jiri Kosina
SUSE Labs