linux-kernel - Re: [PATCH] efi/riscv: Remove the useless failure return message print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQRzBOu5Ml9gJbEN@pie>
Date: Fri, 31 Oct 2025 08:27:48 +0000
From: Yao Zi <ziyao@...root.org>
To: Ard Biesheuvel <ardb@...nel.org>
Cc: Qiang Ma <maqianga@...ontech.com>, pjw@...nel.org, palmer@...belt.com,
	aou@...s.berkeley.edu, alex@...ti.fr, linux-efi@...r.kernel.org,
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] efi/riscv: Remove the useless failure return message
 print

On Fri, Oct 31, 2025 at 07:52:10AM +0100, Ard Biesheuvel wrote:
> On Fri, 31 Oct 2025 at 05:12, Yao Zi <ziyao@...root.org> wrote:
> >
> > On Fri, Oct 31, 2025 at 10:43:28AM +0800, Qiang Ma wrote:
> > > In the efi_create_mapping() in arch/riscv/kernel/efi.c,
> > > the return value is always 0, and this debug message
> > > is unnecessary. So, remove it.
> >
> > Should we make efi_create_mapping() return void at the same time, if it
> > will never fail?
> >
> 
> No.

Oops, seems a silly question here. Sorry for the noise.

Best regards,
Yao Zi