linux-kernel - Re: [RFC PATCH-v2 1/3] dt-bindings: i3c: snps: Add Altera SoCFPGA compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4bba6dc8-130b-4252-b6a8-671696b72c8c@kernel.org>
Date: Fri, 31 Oct 2025 09:37:53 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: adrianhoyin.ng@...era.com, alexandre.belloni@...tlin.com,
 Frank.Li@....com, wsa+renesas@...g-engineering.com, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, dinguyen@...nel.org,
 linux-i3c@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH-v2 1/3] dt-bindings: i3c: snps: Add Altera SoCFPGA
 compatible

On 31/10/2025 09:27, adrianhoyin.ng@...era.com wrote:
> From: Adrian Ng Ho Yin <adrianhoyin.ng@...era.com>
> 
> Add the "altr,socfpga-dw-i3c-master" compatible string to the
> Synopsys DesignWare I3C master binding. This allows SoCFPGA
> platforms such as Agilex5 to use the generic DW I3C master
> controller while applying any required platform-specific quirks.
> 
> Signed-off-by: Adrian Ng Ho Yin <adrianhoyin.ng@...era.com>
> ---
>  .../devicetree/bindings/i3c/snps,dw-i3c-master.yaml         | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> index 5f6467375811..b382d3a72bf7 100644
> --- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> @@ -14,7 +14,11 @@ allOf:
>  
>  properties:
>    compatible:
> -    const: snps,dw-i3c-master-1.00a
> +    oneOf:
> +      - const: snps,dw-i3c-master-1.00a
> +      - items:
> +          - const: altr,socfpga-dw-i3c-master

You need soc specific compatible (see writing bindings). There is no
such SoC as socfpga. Otherwise please point me to the line in the
*existing* bindings describing this SoC.

Best regards,
Krzysztof