linux-kernel - [PATCH] x86/umip: Use pointer from memcpy() call for assignment in fixup_umip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <33c148ea-e1f3-47ff-8ce5-42a31a545b33@web.de>
Date: Fri, 31 Oct 2025 10:30:26 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: x86@...nel.org, Borislav Petkov <bp@...en8.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>, "H. Peter Anvin" <hpa@...or.com>,
 Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
 Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
 Sean Christopherson <seanjc@...gle.com>, Thomas Gleixner <tglx@...utronix.de>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org,
 Andrew Morton <akpm@...ux-foundation.org>, Andy Lutomirski
 <luto@...nel.org>, Borislav Petkov <bp@...e.de>,
 Brian Gerst <brgerst@...il.com>, Chen Yucong <slaoub@...il.com>,
 Chris Metcalf <cmetcalf@...lanox.com>, Denys Vlasenko <dvlasenk@...hat.com>,
 Miaoqian Lin <linmq006@...il.com>
Subject: [PATCH] x86/umip: Use pointer from memcpy() call for assignment in
 fixup_umip_exception()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Fri, 31 Oct 2025 10:10:44 +0100

A pointer was assigned to a variable. The same pointer was used for
the destination parameter of a memcpy() call.
This function is documented in the way that the same value is returned.
Thus convert two separate statements into a direct variable assignment for
the return value from a memory copy action.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 arch/x86/kernel/umip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/umip.c b/arch/x86/kernel/umip.c
index d432f3824f0c..693905a363eb 100644
--- a/arch/x86/kernel/umip.c
+++ b/arch/x86/kernel/umip.c
@@ -398,8 +398,8 @@ bool fixup_umip_exception(struct pt_regs *regs)
 		if (reg_offset < 0)
 			return false;

-		reg_addr = (unsigned long *)((unsigned long)regs + reg_offset);
-		memcpy(reg_addr, dummy_data, dummy_data_size);
+		reg_addr = memcpy((unsigned long *)((unsigned long)regs + reg_offset),
+				  dummy_data, dummy_data_size);
 	} else {
 		uaddr = insn_get_addr_ref(&insn, regs);
 		if ((unsigned long)uaddr == -1L)
-- 
2.51.1