linux-kernel - Re: [PATCH] media: rc: st_rc: fix reset control resource leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <acbf6f70-8ab8-47b2-b31c-5c01f4d5bb02@foss.st.com>
Date: Fri, 31 Oct 2025 10:49:43 +0100
From: Patrice CHOTARD <patrice.chotard@...s.st.com>
To: Haotian Zhang <vulab@...as.ac.cn>, <sean@...s.org>, <mchehab@...nel.org>
CC: <linux-arm-kernel@...ts.infradead.org>, <linux-media@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: rc: st_rc: fix reset control resource leak



On 10/31/25 07:03, Haotian Zhang wrote:
> The driver calls reset_control_get_optional_exclusive() but never calls
> reset_control_put() in error paths or in the remove function. This causes
> a resource leak when probe fails after successfully acquiring the reset
> control, or when the driver is unloaded.
> 
> Switch to devm_reset_control_get_optional_exclusive() to automatically
> manage the reset control resource.
> 
> Fixes: a4b80242d046 ("media: st-rc: explicitly request exclusive reset control")
> Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>
> ---
>  drivers/media/rc/st_rc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c
> index 6539fa0a6e79..6b70bac5f45d 100644
> --- a/drivers/media/rc/st_rc.c
> +++ b/drivers/media/rc/st_rc.c
> @@ -284,7 +284,7 @@ static int st_rc_probe(struct platform_device *pdev)
>  	else
>  		rc_dev->rx_base = rc_dev->base;
>  
> -	rc_dev->rstc = reset_control_get_optional_exclusive(dev, NULL);
> +	rc_dev->rstc = devm_reset_control_get_optional_exclusive(dev, NULL);
>  	if (IS_ERR(rc_dev->rstc)) {
>  		ret = PTR_ERR(rc_dev->rstc);
>  		goto err;


Reviewed-by: Patrice Chotard <patrice.chotard@...s.st.com>

Thanks
Patrice