linux-kernel - Re: [PATCH v3 3/5] regcache: flat: Remove unneeded check and error message for -ENOMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQSUtutUXeTu/1u9@opensource.cirrus.com>
Date: Fri, 31 Oct 2025 10:51:34 +0000
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Mark Brown <broonie@...nel.org>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Sander Vanheule <sander@...nheule.net>, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Danilo Krummrich <dakr@...nel.org>
Subject: Re: [PATCH v3 3/5] regcache: flat: Remove unneeded check and error
 message for -ENOMEM

On Fri, Oct 31, 2025 at 09:03:18AM +0100, Andy Shevchenko wrote:
> There is a convention in the kernel to avoid error messages
> in the cases of -ENOMEM errors. Besides that, the idea behind
> using struct_size() and other macros from overflow.h is
> to saturate the size that the following allocation call will
> definitely fail, hence the check and the error messaging added
> in regcache_flat_init() are redundant. Remove them.
> 
> Acked-by: Sander Vanheule <sander@...nheule.net>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles