linux-kernel - Re: [PATCH v6 1/7] reset: mpfs: add non-auxiliary bus probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251031-mosaic-trimness-d683527a6866@spud>
Date: Fri, 31 Oct 2025 10:58:29 +0000
From: Conor Dooley <conor@...nel.org>
To: claudiu beznea <claudiu.beznea@...on.dev>
Cc: Conor Dooley <conor.dooley@...rochip.com>,
	Daire McNamara <daire.mcnamara@...rochip.com>,
	pierre-henry.moussay@...rochip.com,
	valentina.fernandezalanis@...rochip.com,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	linux-riscv@...ts.infradead.org, linux-clk@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/7] reset: mpfs: add non-auxiliary bus probing

On Fri, Oct 31, 2025 at 09:20:17AM +0200, claudiu beznea wrote:
> On 10/29/25 18:11, Conor Dooley wrote:
> > -static int mpfs_reset_probe(struct auxiliary_device *adev,
> > -			    const struct auxiliary_device_id *id)
> > +static int mpfs_reset_mfd_probe(struct platform_device *pdev)
> >   {
> > -	struct device *dev = &adev->dev;
> >   	struct reset_controller_dev *rcdev;
> > +	struct device *dev = &pdev->dev;
> > +	struct mpfs_reset *rst;
> > +
> > +	rst = devm_kzalloc(dev, sizeof(*rst), GFP_KERNEL);
> > +	if (!rst)
> > +		return -ENOMEM;
> > +
> > +	rcdev = &rst->rcdev;
> > +	rcdev->dev = dev;
> > +	rcdev->ops = &mpfs_reset_ops;
> > +
> > +	rcdev->of_node = pdev->dev.parent->of_node;
> > +	rcdev->of_reset_n_cells = 1;
> > +	rcdev->of_xlate = mpfs_reset_xlate;
> > +	rcdev->nr_resets = MPFS_NUM_RESETS;
> > +
> > +	rst->regmap = device_node_to_regmap(pdev->dev.parent->of_node);
> > +	if (IS_ERR(rst->regmap))
> > +		dev_err_probe(dev, PTR_ERR(rst->regmap), "Failed to find syscon regmap\n");
> 
> Do you want to continue registering the reset controller here? rcdev->base
> is NULL, thus the reset controller ops will fail, if I'm not wrong.


Oh, good point. That line is missing a return.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)