linux-kernel - [PATCH] atm: solos-pci: Use pointer from memcpy() call for assignment in fpga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <093033d3-0ea3-49a0-83e8-621fc4fe1d24@web.de>
Date: Fri, 31 Oct 2025 12:42:09 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org,
 Chas Williams <3chas3@...il.com>, "David S. Miller" <davem@...emloft.net>,
 David Woodhouse <David.Woodhouse@...el.com>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org,
 Miaoqian Lin <linmq006@...il.com>
Subject: [PATCH] atm: solos-pci: Use pointer from memcpy() call for assignment
 in fpga_tx()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Fri, 31 Oct 2025 12:30:38 +0100

A pointer was assigned to a variable. The same pointer was used for
the destination parameter of a memcpy() call.
This function is documented in the way that the same value is returned.
Thus convert two separate statements into a direct variable assignment for
the return value from a memory copy action.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/atm/solos-pci.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index d3c30a28c410..dc4aa803f3d6 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -1087,10 +1087,11 @@ static uint32_t fpga_tx(struct solos_card *card)
 				oldskb = skb; /* We're done with this skb already */
 			} else if (skb && card->using_dma) {
 				unsigned char *data = skb->data;
-				if ((unsigned long)data & card->dma_alignment) {
-					data = card->dma_bounce + (BUF_SIZE * port);
-					memcpy(data, skb->data, skb->len);
-				}
+
+				if ((unsigned long)data & card->dma_alignment)
+					data = memcpy(card->dma_bounce + (BUF_SIZE * port),
+						      skb->data, skb->len);
+
 				SKB_CB(skb)->dma_addr = dma_map_single(&card->dev->dev, data,
 								       skb->len, DMA_TO_DEVICE);
 				card->tx_skb[port] = skb;
-- 
2.51.1