linux-kernel - Re: [PATCH v2 2/2] dt-bindings: mailbox: qcom: Add IPCC support for Glymur Platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <df62f5f5-3dca-4ffd-a25f-a7e247c8096a@oss.qualcomm.com>
Date: Fri, 31 Oct 2025 10:04:20 +0800
From: Jingyi Wang <jingyi.wang@....qualcomm.com>
To: Bjorn Andersson <andersson@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>
Cc: Manivannan Sadhasivam <mani@...nel.org>,
        Jassi Brar <jassisinghbrar@...il.com>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>, aiqun.yu@....qualcomm.com,
        tingwei.zhang@....qualcomm.com, trilok.soni@....qualcomm.com,
        yijie.yang@....qualcomm.com, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        Sibi Sankar <sibi.sankar@....qualcomm.com>
Subject: Re: [PATCH v2 2/2] dt-bindings: mailbox: qcom: Add IPCC support for
 Glymur Platform



On 10/31/2025 3:11 AM, Bjorn Andersson wrote:
> On Thu, Oct 30, 2025 at 06:53:59AM +0100, Krzysztof Kozlowski wrote:
>> On 29/10/2025 18:23, Bjorn Andersson wrote:
>>> On Wed, Oct 29, 2025 at 04:49:30PM +0100, Krzysztof Kozlowski wrote:
>>>> On 29/10/2025 09:15, Jingyi Wang wrote:
>>>>> diff --git a/include/dt-bindings/mailbox/qcom,glymur-ipcc.h b/include/dt-bindings/mailbox/qcom,glymur-ipcc.h
>>>>> new file mode 100644
>>>>> index 000000000000..3ab8189974a5
>>>>> --- /dev/null
>>>>> +++ b/include/dt-bindings/mailbox/qcom,glymur-ipcc.h
>>>>> @@ -0,0 +1,68 @@
>>>>> +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */
>>>>> +/*
>>>>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
>>>>> + */
>>>>> +
>>>>> +#ifndef __DT_BINDINGS_MAILBOX_IPCC_GLYMUR_H
>>>>> +#define __DT_BINDINGS_MAILBOX_IPCC_GLYMUR_H
>>>>> +
>>>>> +/* Glymur physical client IDs */
>>>>> +#define IPCC_MPROC_AOP			0
>>>>
>>>>
>>>> Here the same - not used by Linux.
>>>
>>> How is this different from e.g.:
>>>
>>> include/dt-bindings/interrupt-controller/arm-gic.h:#define GIC_SPI 0
>>
>> $ git grep GIC_SPI
>> drivers/irqchip/irq-mchp-eic.c
>>
> 
> My interpretation of that snippet (and the other use cases) is that they
> are programmatically constructing the values of a DT property, not that
> they define the SW API.
> 
>> How is this not used by Linux? What is drivers/irqchip/foo.c if not a
>> Linux driver?
>>
> 
> No argument there.
> 
> [..]
>>>
>>>> Or provide explanation in terms what Linux interface you are binding
>>>> here (please focus on Linux or other SW).
>>>>
>>>
>>> Don't we use include/dt-bindings to define hardware constants for use in
>>
>> No, we do not.
>>
> 
> I have completely missed this. Perhaps this is the first use case, but
> the result is non-the-less:
> 
> $ find arch/*/boot/dts/qcom -name '*.h' | wc -l
> 0
> 
> 
> But this makes sense, and I like it.
> 
> @Jingyi, as these header constants are consumed only by DeviceTree
> source, please move them to arch/arm64/boot/dts/qcom/
> 
> Thanks,
> Bjorn

Well noted.

Thanks,
Jingyi