linux-kernel - Re: [PATCH v2] phy: sparx5-serdes: make it selectable for ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5dd8e39e-6fa4-43c0-96b0-d64a03caf3af@gmail.com>
Date: Fri, 31 Oct 2025 13:48:02 +0100
From: Gabor Juhos <j4g8y7@...il.com>
To: Robert Marko <robert.marko@...tura.hr>, vkoul@...nel.org,
 kishon@...nel.org, geert+renesas@...der.be, herve.codina@...tlin.com,
 linux-phy@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc: luka.perkov@...tura.hr, Daniel Machon <daniel.machon@...rochip.com>
Subject: Re: [PATCH v2] phy: sparx5-serdes: make it selectable for
 ARCH_LAN969X

Hi Robert,

2025. 10. 31. 13:18 keltezéssel, Robert Marko írta:
> LAN969x uses the SparX-5 SERDES driver, so make it selectable for
> ARCH_LAN969X.
> 
> Reviewed-by: Daniel Machon <daniel.machon@...rochip.com>
> Signed-off-by: Robert Marko <robert.marko@...tura.hr>
> ---
> Changes in v2:
> * Rebase onto next-20251031
> * Add Reviewed-by tag
> 
>  drivers/phy/microchip/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/microchip/Kconfig b/drivers/phy/microchip/Kconfig
> index 2f0045e874ac..2e6d1224711e 100644
> --- a/drivers/phy/microchip/Kconfig
> +++ b/drivers/phy/microchip/Kconfig
> @@ -6,7 +6,7 @@
>  config PHY_SPARX5_SERDES
>  	tristate "Microchip Sparx5 SerDes PHY driver"
>  	select GENERIC_PHY
> -	depends on ARCH_SPARX5 || COMPILE_TEST
> +	depends on ARCH_SPARX5 || ARCH_LAN969X || COMPILE_TEST
>  	depends on OF
>  	depends on HAS_IOMEM
>  	help

This probably deserves a 'Fixes' tag, as it fixes the following warning:

    WARNING: unmet direct dependencies detected for PHY_SPARX5_SERDES
      Depends on [n]: (ARCH_SPARX5 [=n] || COMPILE_TEST [=n]) && OF [=y] && HAS_IOMEM [=y]
      Selected by [y]:
      - SPARX5_SWITCH [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICROCHIP [=y] && NET_SWITCHDEV [=y] && HAS_IOMEM [=y] && OF [=y] && (ARCH_SPARX5 [=n] || ARCH_LAN969X [=y] || COMPILE_TEST [=n]) && PTP_1588_CLOCK_OPTIONAL [=y] && (BRIDGE [=y] || BRIDGE [=y]=n [=n])

I have seen it on v6.18-rc3, and it is caused by commit 6287982aa549 ("net: ethernet:
microchip: sparx5: make it selectable for ARCH_LAN969X").

Tested-by: Gabor Juhos <j4g8y7@...il.com>