linux-kernel - Re: [PATCH] iio: imu: inv_icm45600: Initializes inv_icm45600_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQSv6xM6j-lpTzdb@smile.fi.intel.com>
Date: Fri, 31 Oct 2025 14:47:39 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: remi.buisson@....com
Cc: Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: imu: inv_icm45600: Initializes
 inv_icm45600_buffer_postdisable sleep

On Fri, Oct 31, 2025 at 10:58:02AM +0000, Remi Buisson via B4 Relay wrote:
> From: Remi Buisson <remi.buisson@....com>

Sorry, but you must write the commit message.

> Fixes: 06674a72cf7a ("iio: imu: inv_icm45600: add buffer support in iio devices")
> ---
> The sleep variable in inv_icm45600_buffer_postdisable could be used without being
> assigned in case f error. It must be initialized to 0 by default.

Why is this in the comment and not in the commit message? Also, can you spell
out the real compilation warning or so?

Otherwise the code might look okay, depending on the context. Again, usually
it's recommended to assign as late as possible to avoid subtle mistakes when
the same variable might be reused in the (future) code.

-- 
With Best Regards,
Andy Shevchenko