linux-kernel - [PATCH] rtlwifi: rtl8188ee: remove an accidental '-' character

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <aQSz3KnK4wFIJoe3@stanley.mountain>
Date: Fri, 31 Oct 2025 16:04:28 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Ping-Ke Shih <pkshih@...ltek.com>,
	Harshit Mogalapalli <harshit.m.mogalapalli@...il.com>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: [PATCH] rtlwifi: rtl8188ee: remove an accidental '-' character

The "->allstasleep" variable is a 1 bit bitfield.  It can only be
0 or 1.  This "= -1" assignement was supposed to be "= 1".  This
doesn't change how the code works, it's just a cleanup.

Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
---
Found with a static checker rule that Harshit and I wrote.

 drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c
index 7252bc621211..7ef57b1c674c 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c
@@ -694,7 +694,7 @@ void rtl88e_set_p2p_ps_offload_cmd(struct ieee80211_hw *hw, u8 p2p_ps_state)
 
 			if (P2P_ROLE_GO == rtlpriv->mac80211.p2p) {
 				p2p_ps_offload->role = 1;
-				p2p_ps_offload->allstasleep = -1;
+				p2p_ps_offload->allstasleep = 1;
 			} else {
 				p2p_ps_offload->role = 0;
 			}
-- 
2.51.0