linux-kernel - Re: [PATCH] maple_tree: fix tracepoint string pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <kfzgcg2ir4v3evxnlfui7jrip3zozsmpxj6mdisshw5won6qvs@n63xfjfnlxkn>
Date: Fri, 31 Oct 2025 09:08:28 -0400
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: Martin Kaiser <martin@...ser.cx>
Cc: Andrew Morton <akpm@...ux-foundation.org>, maple-tree@...ts.infradead.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] maple_tree: fix tracepoint string pointers

* Martin Kaiser <martin@...ser.cx> [251031 06:23]:
> Thus wrote Andrew Morton (akpm@...ux-foundation.org):
> 
> > > -	trace_ma_op(__func__, mas);
> > > +	trace_ma_op(TP_FCT, mas);
> 
> 
> > What could cause the storage for __func__ to disappear as you suggest?
> 
> I see your point. For __func__, the compiler generates a local symbol in
> .rodata that should always be accessible by its address.
> 
> One case that doesn't work without my patch would be trace-cmd record to save
> the binary ringbuffer and trace-cmd report to parse it in userspace. The
> address of __func__ can't be dereferenced from userspace but tracepoint_string
> will add an entry to /sys/kernel/tracing/printk_formats
> 


Thanks.

Is there some way to detect such things at compile?

Acked-by: Liam R. Howlett <Liam.Howlett@...cle.com>