[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20251101051723.917688-1-niravkumarlaxmidas.rabara@altera.com>
Date: Sat, 1 Nov 2025 13:17:23 +0800
From: niravkumarlaxmidas.rabara@...era.com
To: dinguyen@...nel.org,
bp@...en8.de,
tony.luck@...el.com
Cc: thor.thayer@...ux.intel.com,
linux-edac@...r.kernel.org,
linux-kernel@...r.kernel.org,
Niravkumar L Rabara <niravkumarlaxmidas.rabara@...era.com>
Subject: [PATCH] EDAC/altera: Use INTTEST register for Ethernet and USB SBE injection
From: Niravkumar L Rabara <niravkumarlaxmidas.rabara@...era.com>
The current single-bit error injection mechanism flips bits directly in
ECC RAM by performing write and read operations. When the ECC RAM is
actively used by the Ethernet or USB controller, this approach sometimes
trigger a false double-bit error.
Switch both Ethernet and USB EDAC devices to use the INTTEST register
(altr_edac_a10_device_inject_fops) for single-bit error injection,
similar to the existing double-bit error injection method.
Fixes: 064acbd4f4ab ("EDAC, altera: Add Stratix10 peripheral support")
Signed-off-by: Niravkumar L Rabara <niravkumarlaxmidas.rabara@...era.com>
---
drivers/edac/altera_edac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
index 103b2c2eba2a..5c5d4585d8ae 100644
--- a/drivers/edac/altera_edac.c
+++ b/drivers/edac/altera_edac.c
@@ -1357,7 +1357,7 @@ static const struct edac_device_prv_data a10_enetecc_data = {
.ue_set_mask = ALTR_A10_ECC_TDERRA,
.set_err_ofst = ALTR_A10_ECC_INTTEST_OFST,
.ecc_irq_handler = altr_edac_a10_ecc_irq,
- .inject_fops = &altr_edac_a10_device_inject2_fops,
+ .inject_fops = &altr_edac_a10_device_inject_fops,
};
#endif /* CONFIG_EDAC_ALTERA_ETHERNET */
@@ -1447,7 +1447,7 @@ static const struct edac_device_prv_data a10_usbecc_data = {
.ue_set_mask = ALTR_A10_ECC_TDERRA,
.set_err_ofst = ALTR_A10_ECC_INTTEST_OFST,
.ecc_irq_handler = altr_edac_a10_ecc_irq,
- .inject_fops = &altr_edac_a10_device_inject2_fops,
+ .inject_fops = &altr_edac_a10_device_inject_fops,
};
#endif /* CONFIG_EDAC_ALTERA_USB */
--
2.25.1
Powered by blists - more mailing lists