linux-kernel - Re: [PATCH 13/15] arm64: dts: mediatek: mt7981b: Add wifi memory region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <548101c6c887299b3c39f294e376c782e0bd2160.camel@collabora.com>
Date: Sat, 01 Nov 2025 13:40:06 +0100
From: Sjoerd Simons <sjoerd@...labora.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,  Matthias Brugger
 <matthias.bgg@...il.com>, Ryder Lee <ryder.lee@...iatek.com>, Jianjun Wang	
 <jianjun.wang@...iatek.com>, Bjorn Helgaas <bhelgaas@...gle.com>, Lorenzo
 Pieralisi <lpieralisi@...nel.org>, Krzysztof Wilczyński
 <kwilczynski@...nel.org>,  Manivannan Sadhasivam	 <mani@...nel.org>,
 Chunfeng Yun <chunfeng.yun@...iatek.com>, Vinod Koul	 <vkoul@...nel.org>,
 Kishon Vijay Abraham I <kishon@...nel.org>, Lee Jones	 <lee@...nel.org>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"	
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski	
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Lorenzo Bianconi	
 <lorenzo@...nel.org>, Felix Fietkau <nbd@....name>
Cc: kernel@...labora.com, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-mediatek@...ts.infradead.org, linux-pci@...r.kernel.org, 
	linux-phy@...ts.infradead.org, netdev@...r.kernel.org, Daniel Golle
	 <daniel@...rotopia.org>, Bryan Hinton <bryan@...anhinton.com>
Subject: Re: [PATCH 13/15] arm64: dts: mediatek: mt7981b: Add wifi memory
 region

On Thu, 2025-10-16 at 13:28 +0200, AngeloGioacchino Del Regno wrote:
> Il 16/10/25 12:08, Sjoerd Simons ha scritto:
> > Add required memory region for the builtin wifi block. Disable the block
> > by default as it won't function properly without at least pin muxing.
> > 
> > Signed-off-by: Sjoerd Simons <sjoerd@...labora.com>
> 
> You should split this commit in two:
>   - Add wifi memory region
>   - Disable wifi by default

Will split.

> Regarding the second commit, you have to re-enable the wifi node in all of
> the currently supported MT7981b devices, including:
>   - Xiaomi AX3000T
>   - Cudy WR3000 V1
> 
> While I agree that without pin muxing the wifi may not properly work, it is
> unclear whether the aforementioned devices are pre-setting the pinmux in the
> bootloader before booting Linux.
> 
> In case those do, you'd be "breaking" WiFi on two routers here.

Wifi will never have worked on those upstream; The driver hits an unconditional -EINVAL during probe
due to the  missing memory-region this patch adds. I'll make sure to note that in the new disable
patch.

-- 
Sjoerd Simons <sjoerd@...labora.com>