linux-kernel - Re: [PATCH] arm64: dts: rockchip: fix eMMC corruption on NanoPC-T6 with A3A444 chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e52de2b5-bf10-ce0e-66b7-66b1c46525f3@manjaro.org>
Date: Sat, 01 Nov 2025 13:50:59 +0100
From: "Dragan Simic" <dsimic@...jaro.org>
To: "Heiko Stuebner" <heiko@...ech.de>
Cc: "Shawn Lin" <shawn.lin@...k-chips.com>, "Tianling Shen" <cnsztl@...il.com>, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org, "Rob Herring" <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>, "Grzegorz Sterniczuk" <grzegorz@...rnicz.uk>, "Jonas Karlman" <jonas@...boo.se>, "Jianfeng Liu" <liujianfeng1994@...il.com>
Subject: Re: [PATCH] arm64: dts: rockchip: fix eMMC corruption on NanoPC-T6 with A3A444 chips

Hello Heiko,

On Saturday, November 01, 2025 12:54 CET, Heiko Stuebner <heiko@...ech.de> wrote:
> Am Montag, 27. Oktober 2025, 18:34:25 Mitteleuropäische Normalzeit schrieb Tianling Shen:
> > On 2025/10/20 12:44, Tianling Shen wrote:
> > > On 2025/10/20 9:53, Shawn Lin wrote:
> > >> On 2025/10/17 Friday 15:39, Tianling Shen wrote:
> > >>> From: Grzegorz Sterniczuk <grzegorz@...rnicz.uk>
> > >>>
> > >>> Some NanoPC-T6 boards with A3A444 eMMC chips experience I/O errors and
> > >>> corruption when using HS400 mode. Downgrade to HS200 mode to ensure
> > >>> stable operation.
> > >>
> > >> May I ask you to test another patch I just posted to see if it fixes
> > >> your issue?
> > >>
> > >> https://patchwork.kernel.org/project/linux-mmc/ 
> > >> patch/1760924981-52339-1- git-send-email-shawn.lin@...k-chips.com/
> > > 
> > > Thank you for the patch! I will ask my friend to test it but he uses 
> > > this board as a home router, so it may take a few days or weeks to 
> > > report the result.
> > 
> > Hi all, sorry for the late. My friend has tested this patch and it works 
> > fine after 50 times dd operation. A big thanks to Shawn!
> 
> So I guess, we don't need the patch reducing the speed anymore, right?

Exactly, the approach of lowering the speed of eMMC to improve
its reliability is no longer needed, thanks to Shawn correcting
the DLL_STRBIN_TAPNUM_DEFAULT value in the above-linked patch.

We just need to test does HS400 work on the ROCK 5 ITX reliably
as well, so the previous lowering to HS200 in commit b36402e4a077
("arm64: dts: rockchip: slow down emmc freq for rock 5 itx", 2025-
02-28) could be reverted as no longer needed.

> > And hi Jianfeng, I found you made a similiar patch[1] for the ROCK 5 ITX 
> > board to lower down the mmc speed, could you please check if this patch 
> > also fixes your issue?
> > 
> > [1] https://lore.kernel.org/linux-rockchip/20250228143341.70244-1-liujianfeng1994@gmail.com/
> > 
> > >>> Signed-off-by: Grzegorz Sterniczuk <grzegorz@...rnicz.uk>
> > >>> Signed-off-by: Tianling Shen <cnsztl@...il.com>
> > >>> ---
> > >>>   arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtsi | 3 +--
> > >>>   1 file changed, 1 insertion(+), 2 deletions(-)
> > >>>
> > >>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtsi b/ 
> > >>> arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtsi
> > >>> index fafeabe9adf9..5f63f38f7326 100644
> > >>> --- a/arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtsi
> > >>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtsi
> > >>> @@ -717,8 +717,7 @@ &sdhci {
> > >>>       no-sd;
> > >>>       non-removable;
> > >>>       max-frequency = <200000000>;
> > >>> -    mmc-hs400-1_8v;
> > >>> -    mmc-hs400-enhanced-strobe;
> > >>> +    mmc-hs200-1_8v;
> > >>>       status = "okay";
> > >>>   };