lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202511020129.b8wpSSt0-lkp@intel.com>
Date: Sun, 2 Nov 2025 01:49:18 +0800
From: kernel test robot <lkp@...el.com>
To: Jingyi Wang <jingyi.wang@....qualcomm.com>,
	Bjorn Andersson <andersson@...nel.org>,
	Mathieu Poirier <mathieu.poirier@...aro.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Manivannan Sadhasivam <mani@...nel.org>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	aiqun.yu@....qualcomm.com, tingwei.zhang@....qualcomm.com,
	trilok.soni@....qualcomm.com, yijie.yang@....qualcomm.com,
	linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jingyi Wang <jingyi.wang@....qualcomm.com>,
	Gokul krishna Krishnakumar <Gokul.krishnakumar@....qualcomm>
Subject: Re: [PATCH v2 4/7] remoteproc: qcom: pas: Add late attach support
 for subsystems

Hi Jingyi,

kernel test robot noticed the following build errors:

[auto build test ERROR on aaa9c3550b60d6259d6ea8b1175ade8d1242444e]

url:    https://github.com/intel-lab-lkp/linux/commits/Jingyi-Wang/dt-bindings-remoteproc-qcom-sm8550-pas-Add-Kaanapali-ADSP/20251029-163330
base:   aaa9c3550b60d6259d6ea8b1175ade8d1242444e
patch link:    https://lore.kernel.org/r/20251029-knp-remoteproc-v2-4-6c81993b52ea%40oss.qualcomm.com
patch subject: [PATCH v2 4/7] remoteproc: qcom: pas: Add late attach support for subsystems
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20251102/202511020129.b8wpSSt0-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project cc271437553452ede002d871d32abc02084341a8)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251102/202511020129.b8wpSSt0-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511020129.b8wpSSt0-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/remoteproc/qcom_q6v5_wcss.c:1018:84: error: too few arguments to function call, expected 7, have 6
    1018 |         ret = qcom_q6v5_init(&wcss->q6v5, pdev, rproc, desc->crash_reason_smem, NULL, NULL);
         |               ~~~~~~~~~~~~~~                                                              ^
   drivers/remoteproc/qcom_q6v5.h:55:5: note: 'qcom_q6v5_init' declared here
      55 | int qcom_q6v5_init(struct qcom_q6v5 *q6v5, struct platform_device *pdev,
         |     ^              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      56 |                    struct rproc *rproc, int crash_reason, const char *load_state,
         |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      57 |                    bool early_boot, void (*handover)(struct qcom_q6v5 *q6v5));
         |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.


vim +1018 drivers/remoteproc/qcom_q6v5_wcss.c

0af65b9b915e52 Govind Singh          2021-01-29   971  
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07   972  static int q6v5_wcss_probe(struct platform_device *pdev)
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07   973  {
6549f42c3d1795 Govind Singh          2021-01-29   974  	const struct wcss_data *desc;
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07   975  	struct q6v5_wcss *wcss;
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07   976  	struct rproc *rproc;
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07   977  	int ret;
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07   978  
6549f42c3d1795 Govind Singh          2021-01-29   979  	desc = device_get_match_data(&pdev->dev);
6549f42c3d1795 Govind Singh          2021-01-29   980  	if (!desc)
6549f42c3d1795 Govind Singh          2021-01-29   981  		return -EINVAL;
6549f42c3d1795 Govind Singh          2021-01-29   982  
41854ea92baad3 Andrew Davis          2024-01-23   983  	rproc = devm_rproc_alloc(&pdev->dev, pdev->name, desc->ops,
6549f42c3d1795 Govind Singh          2021-01-29   984  				 desc->firmware_name, sizeof(*wcss));
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07   985  	if (!rproc) {
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07   986  		dev_err(&pdev->dev, "failed to allocate rproc\n");
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07   987  		return -ENOMEM;
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07   988  	}
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07   989  
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07   990  	wcss = rproc->priv;
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07   991  	wcss->dev = &pdev->dev;
0af65b9b915e52 Govind Singh          2021-01-29   992  
0af65b9b915e52 Govind Singh          2021-01-29   993  	wcss->version = desc->version;
0af65b9b915e52 Govind Singh          2021-01-29   994  	wcss->requires_force_stop = desc->requires_force_stop;
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07   995  
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07   996  	ret = q6v5_wcss_init_mmio(wcss, pdev);
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07   997  	if (ret)
41854ea92baad3 Andrew Davis          2024-01-23   998  		return ret;
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07   999  
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07  1000  	ret = q6v5_alloc_memory_region(wcss);
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07  1001  	if (ret)
41854ea92baad3 Andrew Davis          2024-01-23  1002  		return ret;
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07  1003  
0af65b9b915e52 Govind Singh          2021-01-29  1004  	if (wcss->version == WCSS_QCS404) {
0af65b9b915e52 Govind Singh          2021-01-29  1005  		ret = q6v5_wcss_init_clock(wcss);
0af65b9b915e52 Govind Singh          2021-01-29  1006  		if (ret)
41854ea92baad3 Andrew Davis          2024-01-23  1007  			return ret;
0af65b9b915e52 Govind Singh          2021-01-29  1008  
0af65b9b915e52 Govind Singh          2021-01-29  1009  		ret = q6v5_wcss_init_regulator(wcss);
0af65b9b915e52 Govind Singh          2021-01-29  1010  		if (ret)
41854ea92baad3 Andrew Davis          2024-01-23  1011  			return ret;
0af65b9b915e52 Govind Singh          2021-01-29  1012  	}
0af65b9b915e52 Govind Singh          2021-01-29  1013  
0af65b9b915e52 Govind Singh          2021-01-29  1014  	ret = q6v5_wcss_init_reset(wcss, desc);
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07  1015  	if (ret)
41854ea92baad3 Andrew Davis          2024-01-23  1016  		return ret;
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07  1017  
c1fe10d238c025 Sibi Sankar           2021-09-16 @1018  	ret = qcom_q6v5_init(&wcss->q6v5, pdev, rproc, desc->crash_reason_smem, NULL, NULL);
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07  1019  	if (ret)
41854ea92baad3 Andrew Davis          2024-01-23  1020  		return ret;
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07  1021  
25f9f5a2107fdc Bjorn Andersson       2020-05-14  1022  	qcom_add_glink_subdev(rproc, &wcss->glink_subdev, "q6wcss");
5b9f51b200dcb2 Dmitry Baryshkov      2024-06-22  1023  	qcom_add_pdm_subdev(rproc, &wcss->pdm_subdev);
8a226e2c71bb37 Sivaprakash Murugesan 2020-05-01  1024  	qcom_add_ssr_subdev(rproc, &wcss->ssr_subdev, "q6wcss");
8a226e2c71bb37 Sivaprakash Murugesan 2020-05-01  1025  
60e7c43e61c9a6 Joe Hattori           2024-11-08  1026  	if (desc->ssctl_id) {
0af65b9b915e52 Govind Singh          2021-01-29  1027  		wcss->sysmon = qcom_add_sysmon_subdev(rproc,
0af65b9b915e52 Govind Singh          2021-01-29  1028  						      desc->sysmon_name,
0af65b9b915e52 Govind Singh          2021-01-29  1029  						      desc->ssctl_id);
60e7c43e61c9a6 Joe Hattori           2024-11-08  1030  		if (IS_ERR(wcss->sysmon)) {
60e7c43e61c9a6 Joe Hattori           2024-11-08  1031  			ret = PTR_ERR(wcss->sysmon);
60e7c43e61c9a6 Joe Hattori           2024-11-08  1032  			goto deinit_remove_subdevs;
60e7c43e61c9a6 Joe Hattori           2024-11-08  1033  		}
60e7c43e61c9a6 Joe Hattori           2024-11-08  1034  	}
0af65b9b915e52 Govind Singh          2021-01-29  1035  
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07  1036  	ret = rproc_add(rproc);
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07  1037  	if (ret)
60e7c43e61c9a6 Joe Hattori           2024-11-08  1038  		goto remove_sysmon_subdev;
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07  1039  
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07  1040  	platform_set_drvdata(pdev, rproc);
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07  1041  
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07  1042  	return 0;
60e7c43e61c9a6 Joe Hattori           2024-11-08  1043  
60e7c43e61c9a6 Joe Hattori           2024-11-08  1044  remove_sysmon_subdev:
60e7c43e61c9a6 Joe Hattori           2024-11-08  1045  	if (desc->ssctl_id)
60e7c43e61c9a6 Joe Hattori           2024-11-08  1046  		qcom_remove_sysmon_subdev(wcss->sysmon);
60e7c43e61c9a6 Joe Hattori           2024-11-08  1047  deinit_remove_subdevs:
60e7c43e61c9a6 Joe Hattori           2024-11-08  1048  	qcom_q6v5_deinit(&wcss->q6v5);
60e7c43e61c9a6 Joe Hattori           2024-11-08  1049  	qcom_remove_glink_subdev(rproc, &wcss->glink_subdev);
60e7c43e61c9a6 Joe Hattori           2024-11-08  1050  	qcom_remove_pdm_subdev(rproc, &wcss->pdm_subdev);
60e7c43e61c9a6 Joe Hattori           2024-11-08  1051  	qcom_remove_ssr_subdev(rproc, &wcss->ssr_subdev);
60e7c43e61c9a6 Joe Hattori           2024-11-08  1052  	return ret;
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07  1053  }
3a3d4163e0bfde Sricharan Ramabadhran 2018-06-07  1054  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ