linux-kernel - Re: [PATCH net-next 0/6] xfrm docs update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7148e00e-14c4-4eb7-a940-112e86902bc2@infradead.org>
Date: Fri, 31 Oct 2025 21:58:33 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Bagas Sanjaya <bagasdotme@...il.com>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Linux Documentation <linux-doc@...r.kernel.org>,
 Linux Networking <netdev@...r.kernel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Jonathan Corbet <corbet@....net>,
 Steffen Klassert <steffen.klassert@...unet.com>,
 Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH net-next 0/6] xfrm docs update

On 10/29/25 1:26 AM, Bagas Sanjaya wrote:
> Hi,
> 
> Here are xfrm documentation patches. Patches [1-4/6] are formatting polishing;
> [5/6] groups the docs and [6/6] adds MAINTAINERS entries for them.
> 
> Enjoy!
> 
> Bagas Sanjaya (6):
>   Documentation: xfrm_device: Wrap iproute2 snippets in literal code
>     block
>   Documentation: xfrm_device: Use numbered list for offloading steps
>   Documentation: xfrm_device: Separate hardware offload sublists
>   Documentation: xfrm_sync: Properly reindent list text
>   net: Move XFRM documentation into its own subdirectory
>   MAINTAINERS: Add entry for XFRM documentation

LGTM.  Thanks.

for the series:
Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
Tested-by: Randy Dunlap <rdunlap@...radead.org>

OK, one small nit. 3 of the section headings end with ':'
that should not be there.  See xfrm/index.html:

XFRM Framework
XFRM device - offloading the IPsec computations
  Overview
  Callbacks to implement
  Flow
XFRM proc - /proc/net/xfrm_* files
Transformation Statistics
XFRM sync
  1) Message Structure
  2) TLVS reflect the different parameters:
  3) Default configurations for the parameters:
  4) Message types
  Exceptions to threshold settings
XFRM Syscall
  /proc/sys/net/core/xfrm_* Variables:

Oh, and could/should
  Exceptions to threshold settings
be numbered, 5) ? It looks odd to be unnumbered.

-- 
~Randy