linux-kernel - Re: [PATCH 12/13] media: i2c: ov5647: Use the same PLL config for full, 1080p, and binned modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <l2a7xmbcjujgprlnyduxgbif7xfyez3kgsoqbg6mjk3bivlsro@p5rpiidtk7kj>
Date: Sun, 2 Nov 2025 12:16:51 +0100
From: Jacopo Mondi <jacopo.mondi@...asonboard.com>
To: Jai Luthra <jai.luthra@...asonboard.com>
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	Dave Stevenson <dave.stevenson@...pberrypi.com>, Jacopo Mondi <jacopo@...ndi.org>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, Kieran Bingham <kieran.bingham@...asonboard.com>, 
	David Plowman <david.plowman@...pberrypi.com>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, 
	Peter Robinson <pbrobinson@...il.com>, Stefan Wahren <wahrenst@....net>, 
	"Ivan T. Ivanov" <iivanov@...e.de>
Subject: Re: [PATCH 12/13] media: i2c: ov5647: Use the same PLL config for
 full, 1080p, and binned modes

Hi Jai

On Tue, Oct 28, 2025 at 12:57:23PM +0530, Jai Luthra wrote:
> From: Dave Stevenson <dave.stevenson@...pberrypi.com>
>
> In order to simplify the driver slightly, use the same PLL
> configuration, and hence pixel rate and link frequency (to be
> added) for the full, 1080p, and binned modes.
>
> Signed-off-by: Dave Stevenson <dave.stevenson@...pberrypi.com>
> Signed-off-by: Jai Luthra <jai.luthra@...asonboard.com>
> ---
>  drivers/media/i2c/ov5647.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c
> index a0aaf83759e089aea727c44b614c6a9f3237586c..be0b96c4372ae0c6d8fc57280b195d6069dd7019 100644
> --- a/drivers/media/i2c/ov5647.c
> +++ b/drivers/media/i2c/ov5647.c
> @@ -252,7 +252,7 @@ static struct regval_list ov5647_2592x1944_10bpp[] = {
>  };
>
>  static struct regval_list ov5647_1080p30_10bpp[] = {
> -	{0x3036, 0x62},
> +	{0x3036, 0x69},
>  	{0x3821, 0x00},
>  	{0x3820, 0x00},
>  	{0x3612, 0x5b},
> @@ -288,7 +288,7 @@ static struct regval_list ov5647_1080p30_10bpp[] = {
>  };
>
>  static struct regval_list ov5647_2x2binned_10bpp[] = {
> -	{0x3036, 0x62},
> +	{0x3036, 0x69},
>  	{0x3821, 0x01},
>  	{0x3820, 0x41},
>  	{0x3612, 0x59},
> @@ -396,7 +396,7 @@ static const struct ov5647_mode ov5647_modes[] = {
>  			.width		= 1928,
>  			.height		= 1080,
>  		},
> -		.pixel_rate	= 81666700,
> +		.pixel_rate	= 87500000,

I get a value of 87499965, so I guess this is correct approximation

Reviewed-by: Jacopo Mondi <jacopo.mondi@...asonboard.com>

Thanks
  j

>  		.hts		= 2416,
>  		.vts		= 0x450,
>  		.reg_list	= ov5647_1080p30_10bpp,
> @@ -417,7 +417,7 @@ static const struct ov5647_mode ov5647_modes[] = {
>  			.width		= 2592,
>  			.height		= 1944,
>  		},
> -		.pixel_rate	= 81666700,
> +		.pixel_rate	= 87500000,
>  		.hts		= 1896,
>  		.vts		= 0x59b,
>  		.reg_list	= ov5647_2x2binned_10bpp,
>
> --
> 2.51.0
>