linux-kernel - Re: [PATCH net-next 6/6] net/mlx5e: Convert to new hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4d9a2c4c-373a-4ab5-af8d-474212e21762@gmail.com>
Date: Sun, 2 Nov 2025 14:14:47 +0200
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, Tariq Toukan <tariqt@...dia.com>
Cc: Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Saeed Mahameed <saeedm@...dia.com>,
 Leon Romanovsky <leon@...nel.org>, Jason Gunthorpe <jgg@...pe.ca>,
 Mark Bloch <mbloch@...dia.com>, Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>,
 Richard Cochran <richardcochran@...il.com>, linux-rdma@...r.kernel.org,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org, bpf@...r.kernel.org,
 Gal Pressman <gal@...dia.com>, Carolina Jubran <cjubran@...dia.com>,
 Cosmin Ratiu <cratiu@...dia.com>
Subject: Re: [PATCH net-next 6/6] net/mlx5e: Convert to new hwtstamp_get/set
 interface

On 01/11/2025 1:42, Jakub Kicinski wrote:
> On Thu, 30 Oct 2025 12:25:10 +0200 Tariq Toukan wrote:
>> -		err = mlx5e_hwstamp_config_no_ptp_rx(priv,
>> -						     config.rx_filter != HWTSTAMP_FILTER_NONE);
>> +		err = mlx5e_hwstamp_config_no_ptp_rx(
>> +			priv, config->rx_filter != HWTSTAMP_FILTER_NONE);
> 
> FWIW I think this formatting is even worse than going over 80 :(
> 

I'm trying to minimize checkpatch warnings while preserving code 
readability.

IIRC, clang-format produces such open ended code lines, so I thought 
this would be more acceptable.

In any case, I don't mind going with the over 80 option next time.