linux-kernel - Re: [PATCH] random: remove unused get_random_var

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQdRQWiOpnt_RGX0@zx2c4.com>
Date: Sun, 2 Nov 2025 13:40:33 +0100
From: "Jason A. Donenfeld" <Jason@...c4.com>
To: Eric Biggers <ebiggers@...nel.org>
Cc: Theodore Ts'o <tytso@....edu>, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org
Subject: Re: [PATCH] random: remove unused get_random_var_wait functions

On Sat, Nov 01, 2025 at 09:19:41PM -0700, Eric Biggers wrote:
> None of these functions are used, so remove them.
> 
> This renders the two bugs moot:
> 
> - get_random_u64_wait() used the wrong pointer type, making it provide
>   only 32 bits.
> 
> - The '#undef' directive used the wrong identifier, leaving the helper
>   macro defined.

Applied, thanks. And nice catch.

Jason