linux-kernel - Re: [PATCH v5 2/6] media: dt-bindings: Add CAMSS device for Kaanapali

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251102-charming-angelfish-of-experiment-eaa4bc@kuoka>
Date: Sun, 2 Nov 2025 17:06:21 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vijay Kumar Tumati <vijay.tumati@....qualcomm.com>
Cc: Bryan O'Donoghue <bryan.odonoghue@...aro.org>, 
	Hangxiang Ma <hangxiang.ma@....qualcomm.com>, Loic Poulain <loic.poulain@....qualcomm.com>, 
	Robert Foss <rfoss@...nel.org>, Andi Shyti <andi.shyti@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Todor Tomov <todor.too@...il.com>, 
	Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>, Mauro Carvalho Chehab <mchehab@...nel.org>, 
	linux-i2c@...r.kernel.org, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org, aiqun.yu@....qualcomm.com, 
	tingwei.zhang@....qualcomm.com, trilok.soni@....qualcomm.com, yijie.yang@....qualcomm.com, 
	Jingyi Wang <jingyi.wang@....qualcomm.com>, Atiya Kailany <atiya.kailany@....qualcomm.com>
Subject: Re: [PATCH v5 2/6] media: dt-bindings: Add CAMSS device for Kaanapali

On Fri, Oct 31, 2025 at 10:39:44AM -0700, Vijay Kumar Tumati wrote:
> 
> On 10/31/2025 6:50 AM, Bryan O'Donoghue wrote:
> > On 31/10/2025 02:59, Hangxiang Ma wrote:
> > > Add the compatible string "qcom,kaanapali-camss" to support the Camera
> > > Subsystem (CAMSS) on the Qualcomm Kaanapali platform.
> > > 
> > > The Kaanapali platform provides:
> > > - 3 x VFE, 5 RDI per VFE
> > > - 2 x VFE Lite, 4 RDI per VFE Lite
> > > - 3 x CSID
> > > - 2 x CSID Lite
> > > - 6 x CSIPHY
> > > 
> > > Signed-off-by: Hangxiang Ma <hangxiang.ma@....qualcomm.com>
> > > ---
> > >   .../bindings/media/qcom,kaanapali-camss.yaml       | 406
> > > +++++++++++++++++++++
> > >   1 file changed, 406 insertions(+)
> > > 
> > > diff --git
> > > a/Documentation/devicetree/bindings/media/qcom,kaanapali-camss.yaml
> > > b/Documentation/devicetree/bindings/media/qcom,kaanapali-camss.yaml
> > > new file mode 100644
> > > index 000000000000..c34867022fd1
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/media/qcom,kaanapali-camss.yaml
> > > @@ -0,0 +1,406 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/media/qcom,kaanapali-camss.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Qualcomm Kaanapali Camera Subsystem (CAMSS)
> > > +
> > > +maintainers:
> > > +  - Hangxiang Ma <hangxiang.ma@....qualcomm.com>
> > > +
> > > +description:
> > > +  The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms.
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: qcom,kaanapali-camss
> > > +
> > > +  reg:
> > > +    maxItems: 16
> > > +
> > > +  reg-names:
> > > +    items:
> > > +      - const: csid0
> > > +      - const: csid1
> > > +      - const: csid2
> > > +      - const: csid_lite0
> > > +      - const: csid_lite1
> > > +      - const: csiphy0
> > > +      - const: csiphy1
> > > +      - const: csiphy2
> > > +      - const: csiphy3
> > > +      - const: csiphy4
> > > +      - const: csiphy5
> > > +      - const: vfe0
> > > +      - const: vfe1
> > > +      - const: vfe2
> > > +      - const: vfe_lite0
> > > +      - const: vfe_lite1
> > 
> > No test pattern generator on this part ?
> > 
> > We have patches in-flight to add TPG so it makes no sense to omit these
> > registers from current or new submissions.
> > 
> > https://lore.kernel.org/linux-media/20251017-camss_tpg-v5-1-cafe3ad42163@oss.qualcomm.com/
> > 
> > 
> > While we're at it we should consider adding in the other key functional
> > blocks.
> > 
> > OFE, IPE etc, there's no harm in including the registers even if the
> > intention and outcome is never switching that functionality on.
> > 
> Hi Bryan, we have quite a few register spaces on Kaanapali or any other
> target that are not required for the RDI only CAMSS driver, including ICP,

Please read writing bindings doc. It answers this question exactly.

I'm marking it as changes requested in DT patchwork.

Best regards,
Krzysztof