linux-kernel - Re: [PATCH 0/2] platform/x86: ideapad-laptop: Add charge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dfa70284-04ce-482d-8d79-cc0ee8b4bf6d@vdwaa.nl>
Date: Sun, 2 Nov 2025 17:09:13 +0100
From: Jelle van der Waa <jelle@...aa.nl>
To: Rong Zhang <i@...g.moe>, Ike Panhc <ikepanhc@...il.com>,
 Mark Pearson <mpearson-lenovo@...ebb.ca>,
 "Derek J. Clark" <derekjohn.clark@...il.com>,
 Hans de Goede <hansg@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] platform/x86: ideapad-laptop: Add charge_types:Fast
 (Rapid Charge)

On 10/20/25 21:24, Rong Zhang wrote:
> The GBMD/SBMC interface on IdeaPad/ThinkBook supports Rapid Charge mode
> (charge_types: Fast) in addition to Conservation Mode (charge_types:
> Long_Life).
> 
> This patchset exposes these two modes while carefully maintaining their
> mutually exclusive state, which aligns with the behavior of manufacturer
> utilities on Windows.
> 
> Tested on ThinkBook 14 G7+ ASP.

Tested this patch on my Lenovo Ideapad U330p, it now advertises that 
`Fast` is a supported charge_type although my laptop does not seem to 
support it:

[root@...hlinux jelle]# cat /sys/class/power_supply/BAT1/charge_types
Fast [Standard] Long_Life
[root@...hlinux jelle]# echo 'Fast' > 
/sys/class/power_supply/BAT1/charge_types
[root@...hlinux jelle]# cat /sys/class/power_supply/BAT1/charge_types
Fast [Standard] Long_Life

I'm wondering if the battery extension API allows to not advertise a 
property if it isn't supported or if it should at least return -EINVAL.

Greetings,

Jelle van der Waa