linux-kernel - Re: [PATCH v3 2/2] gpu: nova-core: add boot42 support for next-gen GPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b8a8c217-954b-4ffa-bce3-9424134518c8@nvidia.com>
Date: Sat, 1 Nov 2025 20:33:41 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Alexandre Courbot <acourbot@...dia.com>,
 Danilo Krummrich <dakr@...nel.org>
Cc: Joel Fernandes <joelagnelf@...dia.com>, Timur Tabi <ttabi@...dia.com>,
 Alistair Popple <apopple@...dia.com>, Edwin Peer <epeer@...dia.com>,
 Zhi Wang <zhiw@...dia.com>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
 nouveau@...ts.freedesktop.org, rust-for-linux@...r.kernel.org,
 LKML <linux-kernel@...r.kernel.org>,
 Nouveau <nouveau-bounces@...ts.freedesktop.org>
Subject: Re: [PATCH v3 2/2] gpu: nova-core: add boot42 support for next-gen
 GPUs

On 11/1/25 7:41 PM, Alexandre Courbot wrote:
> On Sun Nov 2, 2025 at 9:34 AM JST, John Hubbard wrote:
>> On 10/29/25 7:05 AM, Alexandre Courbot wrote:
...

> We can always add doccomments in the macro, as in the patch below. These
> will be displayed by LSP when one highlights or tries to use one of
> these constants.
> 
> If you think that's adequate, I will send a patch.
> 
> --- a/drivers/gpu/nova-core/bitfield.rs
> +++ b/drivers/gpu/nova-core/bitfield.rs
> @@ -249,7 +249,10 @@ impl $name {
>               { $process:expr } $prim_type:tt $to_type:ty => $res_type:ty $(, $comment:literal)?;
>       ) => {
>           ::kernel::macros::paste!(
> +        /// Inclusive range of the bits covered by this field.
>           const [<$field:upper _RANGE>]: ::core::ops::RangeInclusive<u8> = $lo..=$hi;

Will that let people know that they'll see something like
IMPLEMENTATION_RANGE() for a corresponding .implementation field?

I'm hoping we can somehow create clear and plain documentation for
the various functions that the macro generates.

thanks,
-- 
John Hubbard

> +
> +        /// Mask of the bits making up this field.
>           const [<$field:upper _MASK>]: $storage = {
>               // Generate mask for shifting
>               match ::core::mem::size_of::<$storage>() {
> @@ -260,6 +263,8 @@ impl $name {
>                   _ => ::kernel::build_error!("Unsupported storage type size")
>               }
>           };
> +
> +        /// Shift to apply to a value to align it with the start of this field.
>           const [<$field:upper _SHIFT>]: u32 = $lo;
>           );