linux-kernel - Re: [PATCH v2 0/5] dd ethernet support for RPi5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251102003042.GJ797@pendragon.ideasonboard.com>
Date: Sun, 2 Nov 2025 02:30:42 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Stanimir Varbanov <svarbanov@...e.de>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-rpi-kernel@...ts.infradead.org,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Andrea della Porta <andrea.porta@...e.com>,
	Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Claudiu Beznea <claudiu.beznea@...on.dev>,
	Phil Elwell <phil@...pberrypi.com>,
	Jonathan Bell <jonathan@...pberrypi.com>,
	Dave Stevenson <dave.stevenson@...pberrypi.com>
Subject: Re: [PATCH v2 0/5] dd ethernet support for RPi5

On Fri, Oct 31, 2025 at 05:35:32PM +0200, Stanimir Varbanov wrote:
> On 10/31/25 1:45 PM, Laurent Pinchart wrote:
> > On Fri, Aug 22, 2025 at 12:34:35PM +0300, Stanimir Varbanov wrote:
> >> Hello,
> >>
> >> Changes in v2:
> >>  - In 1/5 updates according to review comments (Nicolas)
> >>  - In 1/5 added Fixes tag (Nicolas)
> >>  - Added Reviewed-by and Acked-by tags.
> >>
> >> v1 can found at [1].
> >>
> >> Comments are welcome!
> > 
> > I'm very happy to see support for Raspberry Pi 5 progressing fast
> > upstream.
> > 
> > I've tested the latest mainline kernel (v6.18-rc3) that includes this
> > series (except for 1/5 that is replaced by
> > https://lore.kernel.org/all/20250820-macb-fixes-v4-0-23c399429164@bootlin.com/
> > as far as I understand). The ethernet controller is successfully
> > detected, and so is the PHY. Link status seems to work fine too, but
> > data doesn't seem to go through when the kernel tries to get a DHCP
> > address (for NFS root). Here's the end of the kernel log (with the
> > messages related to the USB controller stripped out):
> > 
> > [    0.896779] rp1_pci 0002:01:00.0: assign IRQ: got 27
> > [    0.896809] rp1_pci 0002:01:00.0: enabling device (0000 -> 0002)
> > [    0.896840] rp1_pci 0002:01:00.0: enabling bus mastering
> > [    0.931874] macb 1f00100000.ethernet: invalid hw address, using random
> > [    0.944448] macb 1f00100000.ethernet eth0: Cadence GEM rev 0x00070109 at 0x1f00100000 irq 95 (da:2e:6d:9d:52:a4)
> > [    0.989067] macb 1f00100000.ethernet eth0: PHY [1f00100000.ethernet-ffffffff:01] driver [Broadcom BCM54210E] (irq=POLL)
> > [    0.989272] macb 1f00100000.ethernet eth0: configuring for phy/rgmii-id link mode
> > [    0.991271] macb 1f00100000.ethernet: gem-ptp-timer ptp clock registered.
> > [    4.039490] macb 1f00100000.ethernet eth0: Link is Up - 1Gbps/Full - flow control tx
> > [    4.062589] Sending DHCP requests .....
> > [   40.902771] macb 1f00100000.ethernet eth0: Link is Down
> > [   43.975334] macb 1f00100000.ethernet eth0: Link is Up - 1Gbps/Full - flow control tx
> > 
> > I've tried porting patches to drivers/net/phy/broadcom.c from the
> > Raspberry Pi kernel to specifically support the BCM54213PE PHY (which is
> > otherwise identified as a BCM54210E), but they didn't seem to help.
> > 
> > What's the status of ethernet support on the Pi 5, is it supposed to
> > work upstream, or are there pieces still missing ?
> 
> We have this [1] patch queued up, could you give it a try please.
> 
> [1] https://www.spinics.net/lists/kernel/msg5889475.html

It fixes the issue, thank you ! I've sent a patch to add an ethernet0
alias (https://lore.kernel.org/all/20251102002901.467-1-laurent.pinchart@ideasonboard.com),
with that I get working ethernet with a stable MAC address.

-- 
Regards,

Laurent Pinchart