[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <b68d88b8-0eaf-4f9a-a847-befd95659c5c@roeck-us.net>
Date: Sun, 2 Nov 2025 11:08:32 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Cryolitia PukNgae <cryolitia@...ontech.com>
Cc: linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
niecheng1@...ontech.com, zhanjun@...ontech.com,
kylon <3252255+kylon@...rs.noreply.github.com>
Subject: Re: [PATCH] hwmon: (gpd-fan) initialize EC on driver load for Win 4
On Thu, Oct 30, 2025 at 10:30:06PM +0800, Cryolitia PukNgae wrote:
> From: Cryolitia PukNgae <cryolitia@...ontech.com>
>
> The original implement will re-init the EC when it reports a zero
> value, and it's a workaround for the black box buggy firmware.
>
> Now a contributer test and report that, the bug is that, the firmware
> won't initialize the EC on boot, so the EC ramains in unusable status.
> And it won't need to re-init it during runtime. The original implement
> is not perfect, any write command will be ignored until we first read
> it. Just re-init it unconditionally when the driver load could work.
>
> Fixes: 0ab88e239439 ("hwmon: add GPD devices sensor driver")
> Co-developed-by: kylon <3252255+kylon@...rs.noreply.github.com>
> Signed-off-by: kylon <3252255+kylon@...rs.noreply.github.com>
> Link: https://github.com/Cryolitia/gpd-fan-driver/pull/20
> Signed-off-by: Cryolitia PukNgae <cryolitia@...ontech.com>
Applied.
Thanks,
Guenter
Powered by blists - more mailing lists