linux-kernel - Re: [PATCH v5] dt-bindings: gpio: ti,twl4030: Correct the schema $id path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANBuOYqaLMV3rvdf=YcWTjiqn2A3h0a-QYM77VJvSJtSDSe9pQ@mail.gmail.com>
Date: Sun, 2 Nov 2025 21:12:31 +0100
From: Jihed Chaibi <jihed.chaibi.dev@...il.com>
To: linus.walleij@...aro.org, brgl@...ev.pl
Cc: krzk+dt@...nel.org, robh@...nel.org, conor+dt@...nel.org, 
	peter.ujfalusi@...il.com, lee@...nel.org, devicetree@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, shuah@...nel.org, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, aaro.koskinen@....fi, 
	Andreas Kemnade <andreas@...nade.info>, khilman@...libre.com, rogerq@...nel.org, 
	Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH v5] dt-bindings: gpio: ti,twl4030: Correct the schema $id path

On Thu, Aug 21, 2025 at 9:47 PM Jihed Chaibi <jihed.chaibi.dev@...il.com> wrote:
>
> The $id for a binding should match its file path. The ti,twl4030-gpio
> binding is located in the gpio/ subdirectory but was missing this from
> its $id.
>
> Correct the path to follow the standard convention.
>
> Fixes: 842dcff8e2d6 ("dt-bindings: gpio: Convert ti,twl4030-gpio to DT schema")
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@...il.com>
>
> ---
> Changes in v5:
>  - No changes, only added 'Fixes' tag.
>
> Changes in v4:
>  - No changes.
>  - This patch is split from larger series per maintainer feedback.
>  - v3 link:
>     https://lore.kernel.org/all/20250816021523.167049-1-jihed.chaibi.dev@gmail.com/
>
> Changes in v3:
>  - This patch was added to the patch series in v3.
> ---
>  Documentation/devicetree/bindings/gpio/ti,twl4030-gpio.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/ti,twl4030-gpio.yaml b/Documentation/devicetree/bindings/gpio/ti,twl4030-gpio.yaml
> index 5e3e199fd..96d50d14c 100644
> --- a/Documentation/devicetree/bindings/gpio/ti,twl4030-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/ti,twl4030-gpio.yaml
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>  %YAML 1.2
>  ---
> -$id: http://devicetree.org/schemas/ti,twl4030-gpio.yaml#
> +$id: http://devicetree.org/schemas/gpio/ti,twl4030-gpio.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>
>  title: TI TWL4030 GPIO controller
> --
> 2.39.5
>

Hi Bartosz, Linus,

Gentle ping on this fix,
It was reviewed by Krzysztof a couple of months ago. I wonder if it's
ready to be picked up.

Cheers,