linux-kernel - Re: [PATCH 02/11] rtc: ds1685: stop setting max_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ac3e483d-6784-4acc-9fcc-b3bb605ab0c1@kumba.dev>
Date: Sun, 2 Nov 2025 01:51:19 -0500
From: Joshua Kinard <linux@...ba.dev>
To: Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Claudiu Beznea <claudiu.beznea.uj@...renesas.com>,
 Ovidiu Panait <ovidiu.panait.rb@...esas.com>
Cc: linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 02/11] rtc: ds1685: stop setting max_user_freq

On 10/31/2025 20:45, Alexandre Belloni wrote:
> max_user_freq has not been related to the hardware RTC since commit
> 6610e0893b8b ("RTC: Rework RTC code to use timerqueue for events"). Stop
> setting it from individual driver to avoid confusing new contributors.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
> ---
>   drivers/rtc/rtc-ds1685.c   | 3 ---
>   include/linux/rtc/ds1685.h | 1 -
>   2 files changed, 4 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c
> index 97423f1d0361..5fc8e36b1abf 100644
> --- a/drivers/rtc/rtc-ds1685.c
> +++ b/drivers/rtc/rtc-ds1685.c
> @@ -1268,9 +1268,6 @@ ds1685_rtc_probe(struct platform_device *pdev)
>   	rtc_dev->range_min = RTC_TIMESTAMP_BEGIN_2000;
>   	rtc_dev->range_max = RTC_TIMESTAMP_END_2099;
>   
> -	/* Maximum periodic rate is 8192Hz (0.122070ms). */
> -	rtc_dev->max_user_freq = RTC_MAX_USER_FREQ;
> -
>   	/* See if the platform doesn't support UIE. */
>   	if (pdata->uie_unsupported)
>   		clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc_dev->features);
> diff --git a/include/linux/rtc/ds1685.h b/include/linux/rtc/ds1685.h
> index 01da4582db6d..8ec0ebfaef04 100644
> --- a/include/linux/rtc/ds1685.h
> +++ b/include/linux/rtc/ds1685.h
> @@ -324,7 +324,6 @@ struct ds1685_rtc_platform_data {
>   #define RTC_SQW_2HZ		0x0f	/*  0    1   1   1   1  */
>   #define RTC_SQW_0HZ		0x00	/*  0    0   0   0   0  */
>   #define RTC_SQW_32768HZ		32768	/*  1    -   -   -   -  */
> -#define RTC_MAX_USER_FREQ	8192
>   
>   
>   /*
> 

Acked-by: Joshua Kinard <linux@...ba.dev>