linux-kernel - Re: [PATCH] power: supply: Add SC8541 charger drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cmdu4opg34tmoqz6uc5x26afxh7q6shkeoefniottnnk4dpjso@qgpbqoe4ra6y>
Date: Sun, 2 Nov 2025 23:55:04 +0100
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: 1647395606@...com
Cc: linus.walleij@...aro.org, brgl@...ev.pl, linux-kernel@...r.kernel.org, 
	linux-pm@...r.kernel.org, linux-gpio@...r.kernel.org, 
	wangwenqiang <wenqiang.wang@...ot.com>
Subject: Re: [PATCH] power: supply: Add SC8541 charger drivers

Hi,

On Mon, Oct 13, 2025 at 04:54:14PM +0800, 1647395606@...com wrote:
> From: wangwenqiang <wenqiang.wang@...ot.com>
> 
> The SC8541 is a charger pump from South Chip.
> By adjusting the voltage difference between the input and output terminals,
> it can achieve a maximum charging current of 8A.
> It has been verified that this driver can operate normally on the Qualcomm QCS615 platform.
> 
> Signed-off-by: wangwenqiang <wenqiang.wang@...ot.com>
> ---

(incomplete review; I think the nice review from Linus is enough
work for now anyways :))

> +#ifdef CONFIG_MTK_CLASS
> +#include "charger_class.h"
> +#endif /*CONFIG_MTK_CLASS*/
> +
> +#ifdef CONFIG_MTK_CHARGER_V4P19
> +#include "mtk_charger_intf.h"
> +#endif /*CONFIG_MTK_CHARGER_V4P19*/
> +
> +#ifdef CONFIG_SOUTHCHIP_DVCHG_CLASS
> +#include "dvchg_class.h"
> +#endif /*CONFIG_SOUTHCHIP_DVCHG_CLASS*/

Drop all of the above and any future usage of the ifdefs. This kind
of stuff is not acceptable upstream.

> +#define SC8541_DRV_VERSION              "1.0.0_G"

Also drop this. Upstream driver can use the kernel version and it
surely shouldn't be printed as an error in the probe routine.

Greetings,

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)