linux-kernel - Re: [PATCH v2] usb: typec: ucsi: psy: Set max current to zero when disconnected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ew2yygmisdxp5jlefbg64abxzjp5wpxvwnmlhcwedgnzzr2qzs@huem73pm7sr5>
Date: Mon, 3 Nov 2025 00:11:54 +0100
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Jameson Thies <jthies@...gle.com>
Cc: heikki.krogerus@...ux.intel.com, linux-usb@...r.kernel.org, 
	linux-kernel@...r.kernel.org, dmitry.baryshkov@....qualcomm.com, bleung@...omium.org, 
	gregkh@...uxfoundation.org, akuchynski@...omium.org, abhishekpandit@...omium.org, 
	kenny@...ix.com, linux-pm@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2] usb: typec: ucsi: psy: Set max current to zero when
 disconnected

Hi,

On Fri, Oct 17, 2025 at 10:30:53PM +0000, Jameson Thies wrote:
> The ucsi_psy_get_current_max function defaults to 0.1A when it is not
> clear how much current the partner device can support. But this does
> not check the port is connected, and will report 0.1A max current when
> nothing is connected. Update ucsi_psy_get_current_max to report 0A when
> there is no connection.
> 
> v2 changes:
> - added cc stable tag to commit message
> 
> Fixes: af833e7f7db3 ("usb: typec: ucsi: psy: Set current max to 100mA for BC 1.2 and Default")
> Cc: stable@...r.kernel.org
> Signed-off-by: Jameson Thies <jthies@...gle.com>
> Reviewed-by: Benson Leung <bleung@...omium.org>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> Tested-by: Kenneth R. Crudup <kenny@...ix.com>
> ---

With the changelog moved under ---:

Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com>

Greetings,

-- Sebastian

>  drivers/usb/typec/ucsi/psy.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/usb/typec/ucsi/psy.c b/drivers/usb/typec/ucsi/psy.c
> index 62a9d68bb66d..8ae900c8c132 100644
> --- a/drivers/usb/typec/ucsi/psy.c
> +++ b/drivers/usb/typec/ucsi/psy.c
> @@ -145,6 +145,11 @@ static int ucsi_psy_get_current_max(struct ucsi_connector *con,
>  {
>  	u32 pdo;
>  
> +	if (!UCSI_CONSTAT(con, CONNECTED)) {
> +		val->intval = 0;
> +		return 0;
> +	}
> +
>  	switch (UCSI_CONSTAT(con, PWR_OPMODE)) {
>  	case UCSI_CONSTAT_PWR_OPMODE_PD:
>  		if (con->num_pdos > 0) {
> 
> base-commit: e40b984b6c4ce3f80814f39f86f87b2a48f2e662
> -- 
> 2.51.0.858.gf9c4a03a3a-goog
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)