linux-kernel - Re: [PATCH v22 10/28] riscv/mm: Implement map_shadow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2511022341110.1185@angie.orcam.me.uk>
Date: Sun, 2 Nov 2025 23:51:12 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@...am.me.uk>
To: Paul Walmsley <pjw@...nel.org>
cc: Deepak Gupta <debug@...osinc.com>, Thomas Gleixner <tglx@...utronix.de>, 
    Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, 
    Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org, 
    "H. Peter Anvin" <hpa@...or.com>, 
    Andrew Morton <akpm@...ux-foundation.org>, 
    "Liam R. Howlett" <Liam.Howlett@...cle.com>, 
    Vlastimil Babka <vbabka@...e.cz>, 
    Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, 
    Paul Walmsley <paul.walmsley@...ive.com>, 
    Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, 
    Conor Dooley <conor@...nel.org>, Rob Herring <robh@...nel.org>, 
    Krzysztof Kozlowski <krzk+dt@...nel.org>, Arnd Bergmann <arnd@...db.de>, 
    Christian Brauner <brauner@...nel.org>, 
    Peter Zijlstra <peterz@...radead.org>, Oleg Nesterov <oleg@...hat.com>, 
    Eric Biederman <ebiederm@...ssion.com>, Kees Cook <kees@...nel.org>, 
    Jonathan Corbet <corbet@....net>, Shuah Khan <shuah@...nel.org>, 
    Jann Horn <jannh@...gle.com>, Conor Dooley <conor+dt@...nel.org>, 
    Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
    Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
    Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
    Andreas Hindborg <a.hindborg@...nel.org>, 
    Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
    Benno Lossin <lossin@...nel.org>, linux-kernel@...r.kernel.org, 
    linux-fsdevel@...r.kernel.org, linux-mm@...ck.org, 
    linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org, 
    linux-arch@...r.kernel.org, linux-doc@...r.kernel.org, 
    linux-kselftest@...r.kernel.org, alistair.francis@....com, 
    richard.henderson@...aro.org, jim.shu@...ive.com, andybnac@...il.com, 
    kito.cheng@...ive.com, charlie@...osinc.com, atishp@...osinc.com, 
    evan@...osinc.com, cleger@...osinc.com, alexghiti@...osinc.com, 
    samitolvanen@...gle.com, broonie@...nel.org, rick.p.edgecombe@...el.com, 
    rust-for-linux@...r.kernel.org, Zong Li <zong.li@...ive.com>
Subject: Re: [PATCH v22 10/28] riscv/mm: Implement map_shadow_stack()
 syscall

On Fri, 31 Oct 2025, Paul Walmsley wrote:

> This patch introduces a 'checkpatch.pl --strict' message:
> 
> CHECK: Lines should not end with a '('
> #78: FILE: arch/riscv/kernel/usercfi.c:36:
> +	asm goto(
> 
> I'll fix it up here in the event that v22 goes in, but please do the same 
> on your side in case a new version is needed.

 I think this warning is silly for `asm' statements.  It's been common for 
decades to do this to format multi-line `asm' statements, just because it 
makes them so much more readable.  We have roughly two thousand instances 
in our tree already and I would use this style for new code in the parts I 
maintain as well.

 Now having trailing `);' on a separate line is another matter.

  Maciej