linux-kernel - Re: [PATCH 4/7] sysctl: Move jiffies converters to kernel/time/jiffies.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2kjr6dfppy55j54isxxpusuhrbx2vovo2svico5w5k4vqwgadn@xgiza635ugbk>
Date: Sun, 2 Nov 2025 08:54:46 +0100
From: Joel Granados <joel.granados@...nel.org>
To: Kees Cook <kees@...nel.org>, Alexander Viro <viro@...iv.linux.org.uk>, 
	Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>
Cc: linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 4/7] sysctl: Move jiffies converters to
 kernel/time/jiffies.c

On Fri, Oct 17, 2025 at 10:32:14AM +0200, Joel Granados wrote:
> Move integer jiffies converters (proc_dointvec{_,_ms_,_userhz_}jiffies
> and proc_dointvec_ms_jiffies_minmax) to kernel/time/jiffies.c. Error
> stubs for when CONFIG_PRCO_SYSCTL is not defined are not reproduced
> because all the jiffies converters go through proc_dointvec_conv which
> is already stubbed. This is part of the greater effort to move sysctl
> logic out of kernel/sysctl.c thereby reducing merge conflicts in
> kernel/sysctl.c.

Had a warning on linux-next with this. Going to fix it with this

  diff --git i/include/linux/jiffies.h w/include/linux/jiffies.h
  index 57da8eff94d3..fdef2c155c27 100644
  --- i/include/linux/jiffies.h
  +++ w/include/linux/jiffies.h
  @@ -611,6 +611,7 @@ extern unsigned long nsecs_to_jiffies(u64 n);

   #define TIMESTAMP_SIZE 30

  +struct ctl_table;
   int proc_dointvec_jiffies(const struct ctl_table *table, int dir, void *buffer,
                            size_t *lenp, loff_t *ppos);
   int proc_dointvec_ms_jiffies_minmax(const struct ctl_table *table, int dir,
  lines 1-12/12 (END)

Will not resend a V2 since it is such a small change.

Best

-- 

Joel Granados

Download attachment "signature.asc" of type "application/pgp-signature" (660 bytes)