linux-kernel - Re: [PATCH ath-next 2/6] wifi: ath11k: Register debugfs for CFR configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a05ccf8-8850-430c-b008-52b3bc2df431@oss.qualcomm.com>
Date: Sun, 2 Nov 2025 17:21:48 +0800
From: "Yu Zhang(Yuriy)" <yu.zhang@....qualcomm.com>
To: Baochen Qiang <baochen.qiang@....qualcomm.com>, jjohnson@...nel.org
Cc: linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
        ath11k@...ts.infradead.org
Subject: Re: [PATCH ath-next 2/6] wifi: ath11k: Register debugfs for CFR
 configuration



On 10/31/2025 10:43 AM, Baochen Qiang wrote:
> 
> 
> On 10/30/2025 12:31 PM, Yu Zhang(Yuriy) wrote:
> 
>> @@ -88,6 +275,7 @@ void ath11k_cfr_deinit(struct ath11k_base *ab)
>>   			ar = ab->pdevs[i].ar;
>>   			cfr = &ar->cfr;
>>   
>> +			ath11k_cfr_debug_unregister(ar);
>>   			ath11k_cfr_ring_free(ar);
>>   
>>   			spin_lock_bh(&cfr->lut_lock);
>> @@ -140,6 +328,8 @@ int ath11k_cfr_init(struct ath11k_base *ab)
>>   		}
>>   
>>   		cfr->lut_num = num_lut_entries;
>> +
>> +		ath11k_cfr_debug_register(ar);
>>   	}
>>   
>>   	return 0;
> 
> miss _debug_unregister() in the error handling?
> 
> 
The documention for debugfs_create_file() tells us:
  * NOTE: it's expected that most callers should _ignore_ the errors 
returned
  * by this function. Other debugfs functions handle the fact that the 
"dentry"
  * passed to them could be an error and they don't crash in that case.
  * Drivers should generally work fine even if debugfs fails to init anyway.

So IMO any failure to create the file should be ignored.