linux-kernel - Re: [PATCH] of: fdt: Fix the len check in early_init_dt_check_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdW0mLsZmJsWmQEaN=g-kRMMVHaBpRZmQW1VFRqyDvK6UQ@mail.gmail.com>
Date: Mon, 3 Nov 2025 15:51:53 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Yuntao Wang <yuntao.wang@...ux.dev>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>, 
	Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH] of: fdt: Fix the len check in early_init_dt_check_for_elfcorehdr()

Hi Yuntaoi,

On Sun, 2 Nov 2025 at 15:18, Yuntao Wang <yuntao.wang@...ux.dev> wrote:
> The len value is in bytes, while `dt_root_addr_cells + dt_root_size_cells`
> is in cells (4 bytes per cell).
>
> Comparing them directly is incorrect. Convert units before comparison.

Thanks for your patch!

> Fixes: f7e7ce93aac1 ("of: fdt: Add generic support for handling elf core headers property")

My commit consolidated existing code, so you may want to add
Fixes: e62aaeac426ab1dd ("arm64: kdump: provide /proc/vmcore file")
so code in v5.14 and older will be fixed by stable backports, too.

> Signed-off-by: Yuntao Wang <yuntao.wang@...ux.dev>

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds