linux-kernel - Re: [PATCH v8 2/3] firmware: qcom_scm: Support multiple waitq contexts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=Mcj_6g3ory9zqxEWCHmpxh3hf4C-iBK0XT82F8nGVcFKQ@mail.gmail.com>
Date: Mon, 3 Nov 2025 17:59:55 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Shivendra Pratap <shivendra.pratap@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Unnathi Chalicheemala <unnathi.chalicheemala@....qualcomm.com>
Subject: Re: [PATCH v8 2/3] firmware: qcom_scm: Support multiple waitq contexts

On Mon, Nov 3, 2025 at 5:16 PM Shivendra Pratap
<shivendra.pratap@....qualcomm.com> wrote:
>
> >> diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
> >> index 28979f95e51fbee94b84c1570a4d88a76f72db4e..0b6efa7c2bdc25a3ba152c25d5451d1154779ddd 100644
> >> --- a/drivers/firmware/qcom/qcom_scm.c
> >> +++ b/drivers/firmware/qcom/qcom_scm.c
> >> @@ -47,7 +47,7 @@ struct qcom_scm {
> >>         struct clk *iface_clk;
> >>         struct clk *bus_clk;
> >>         struct icc_path *path;
> >> -       struct completion waitq_comp;
> >> +       struct completion *waitq;
> >
> > Why this change? This makes the name less descriptive if not misleading.
>
> Want to make it dynamic array of waitq`s. Should the name be kept as
> struct completion *waitq_comp; ?
>

Yeah, can me waitq_comps if it's plural.

Bart