| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAGb2v67v9fXC-11WAy0-VjJVVz3BVtvbBKiEQu1VVBay6RyFTw@mail.gmail.com>
Date: Tue, 4 Nov 2025 01:40:34 +0800
From: Chen-Yu Tsai <wens@...nel.org>
To: Andre Przywara <andre.przywara@....com>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Jernej Skrabec <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>,
Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, devicetree@...r.kernel.org,
linux-sunxi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, Mikhail Kalashnikov <iuncuim@...il.com>
Subject: Re: [RFC PATCH 2/5] mfd: axp20x: Refactor axp20x_is_polyphase_slave()
On Fri, Sep 19, 2025 at 8:01 AM Andre Przywara <andre.przywara@....com> wrote:
>
> Some X-Powers AXP PMICs allow to combine certain DC/DC rails together in
> a multi-phase fashion. So far we don't actively program those
> connections, but we detect the existing setup, and prevent the connected
> regulators from being re-programmed or turned off.
This last part is a bit incorrect. We simply don't register the secondary
phases as separate regulators anymore. The hardware ignores any changes
to their independent configuration (I assume, since otherwise the hardware
would be really hard to program...).
> At the moment this is
> done in a switch/case construct, listing the known regulator pairs for
> those PMICs supported.
>
> To get rid of this ever growing code section, create a data structure
> that describes the relationship, and have generic code that iterates
> over the entries and checks for matches.
>
> This not only cleans that function up and makes extensions much simpler,
> but also allows to reuse this information for the upcoming programming
> of those poly-phase setups.
>
> Signed-off-by: Andre Przywara <andre.przywara@....com>
> ---
> drivers/regulator/axp20x-regulator.c | 91 ++++++++++++++--------------
> 1 file changed, 45 insertions(+), 46 deletions(-)
>
> diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
> index da891415efc0b..19c9a98d1835a 100644
> --- a/drivers/regulator/axp20x-regulator.c
> +++ b/drivers/regulator/axp20x-regulator.c
> @@ -1481,70 +1481,69 @@ static int axp20x_set_dcdc_workmode(struct regulator_dev *rdev, int id, u32 work
> return regmap_update_bits(rdev->regmap, reg, mask, workmode);
> }
>
> +struct dualphase_regulator {
> + int axp_id;
> + int reg1, reg2;
We don't care about the primary phase. The point is to make the secondary
phases disappear from the kernel's view.
reg1 should be part of the next patch, where you actually care.
> + unsigned int polyphase_reg;
> + unsigned int bitmask;
> +} dualphase_regulators[] = {
> + { AXP323_ID, AXP313A_DCDC1, AXP313A_DCDC2,
> + AXP323_DCDC_MODE_CTRL2, BIT(1), },
> + { AXP803_ID, AXP803_DCDC2, AXP803_DCDC3, AXP803_POLYPHASE_CTRL,
> + AXP803_DCDC23_POLYPHASE_DUAL, },
> + { AXP803_ID, AXP803_DCDC5, AXP803_DCDC6, AXP803_POLYPHASE_CTRL,
> + AXP803_DCDC56_POLYPHASE_DUAL, },
> + /* AXP806's DCDC-A/B/C is a tri-phase regulator */
TODO: ?
ChenYu
> + { AXP806_ID, AXP806_DCDCD, AXP806_DCDCE, AXP806_DCDC_MODE_CTRL2,
> + AXP806_DCDCDE_POLYPHASE_DUAL, },
> + { AXP813_ID, AXP803_DCDC2, AXP803_DCDC3, AXP803_POLYPHASE_CTRL,
> + AXP803_DCDC23_POLYPHASE_DUAL, },
> + { AXP813_ID, AXP803_DCDC5, AXP803_DCDC6, AXP803_POLYPHASE_CTRL,
> + AXP803_DCDC56_POLYPHASE_DUAL, },
> + { AXP15060_ID, AXP15060_DCDC2, AXP15060_DCDC3, AXP15060_DCDC_MODE_CTRL1,
> + AXP15060_DCDC23_POLYPHASE_DUAL_MASK, },
> + { AXP15060_ID, AXP15060_DCDC4, AXP15060_DCDC6, AXP15060_DCDC_MODE_CTRL1,
> + AXP15060_DCDC46_POLYPHASE_DUAL_MASK, },
> +};
> +
> /*
> * This function checks whether a regulator is part of a poly-phase
> * output setup based on the registers settings. Returns true if it is.
> */
> static bool axp20x_is_polyphase_slave(struct axp20x_dev *axp20x, int id)
> {
> + struct dualphase_regulator *dpreg;
> u32 reg = 0;
> + int i;
>
> - /*
> - * Currently in our supported AXP variants, only AXP803, AXP806,
> - * AXP813 and AXP15060 have polyphase regulators.
> - */
> - switch (axp20x->variant) {
> - case AXP803_ID:
> - case AXP813_ID:
> - regmap_read(axp20x->regmap, AXP803_POLYPHASE_CTRL, ®);
> + for (i = 0; i < ARRAY_SIZE(dualphase_regulators); i++) {
> + dpreg = &dualphase_regulators[i];
>
> - switch (id) {
> - case AXP803_DCDC3:
> - return !!(reg & AXP803_DCDC23_POLYPHASE_DUAL);
> - case AXP803_DCDC6:
> - return !!(reg & AXP803_DCDC56_POLYPHASE_DUAL);
> + if (axp20x->variant != dpreg->axp_id)
> + continue;
> + /* Is this the second regulator from a dual-phase pair? */
> + if (id == dpreg->reg2) {
> + regmap_read(axp20x->regmap, dpreg->polyphase_reg, ®);
> +
> + return !!(reg & dpreg->bitmask);
> }
> - break;
> + }
>
> - case AXP806_ID:
> + /*
> + * DCDC-A/B/C can be configured either as a dual-phase (A+B) or
> + * as a triple-phase regulator (A+B+C), but not in any other
> + * combination. Treat this as a special case here.
> + */
> + if (axp20x->variant == AXP806_ID) {
> regmap_read(axp20x->regmap, AXP806_DCDC_MODE_CTRL2, ®);
> -
> - switch (id) {
> - case AXP806_DCDCB:
> + if (id == AXP806_DCDCB)
> return (((reg & AXP806_DCDCABC_POLYPHASE_MASK) ==
> AXP806_DCDCAB_POLYPHASE_DUAL) ||
> ((reg & AXP806_DCDCABC_POLYPHASE_MASK) ==
> AXP806_DCDCABC_POLYPHASE_TRI));
> - case AXP806_DCDCC:
> + if (id == AXP806_DCDCC)
> return ((reg & AXP806_DCDCABC_POLYPHASE_MASK) ==
> AXP806_DCDCABC_POLYPHASE_TRI);
> - case AXP806_DCDCE:
> - return !!(reg & AXP806_DCDCDE_POLYPHASE_DUAL);
> - }
> - break;
> -
> - case AXP15060_ID:
> - regmap_read(axp20x->regmap, AXP15060_DCDC_MODE_CTRL1, ®);
> -
> - switch (id) {
> - case AXP15060_DCDC3:
> - return !!(reg & AXP15060_DCDC23_POLYPHASE_DUAL_MASK);
> - case AXP15060_DCDC6:
> - return !!(reg & AXP15060_DCDC46_POLYPHASE_DUAL_MASK);
> - }
> - break;
> -
> - case AXP323_ID:
> - regmap_read(axp20x->regmap, AXP323_DCDC_MODE_CTRL2, ®);
> -
> - switch (id) {
> - case AXP313A_DCDC2:
> - return !!(reg & BIT(1));
> - }
> - break;
> -
> - default:
> - return false;
> }
>
> return false;
> --
> 2.46.4
>
Powered by blists - more mailing lists