linux-kernel - [PATCH] soundoc: qcom: va-macro: fix resource leak in va_macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251103034735.90-1-vulab@iscas.ac.cn>
Date: Mon,  3 Nov 2025 11:47:35 +0800
From: Haotian Zhang <vulab@...as.ac.cn>
To: srini@...nel.org,
	broonie@...nel.org
Cc: lgirdwood@...il.com,
	jaroslav.kysela@...ex.cz,
	tiwai@...e.com,
	linux-sound@...r.kernel.org,
	linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Haotian Zhang <vulab@...as.ac.cn>
Subject: [PATCH] soundoc: qcom: va-macro: fix resource leak in va_macro_remove()

The va_macro_probe() function calls clk_hw_get_clk() to obtain the
fsgen clock, which increments the clock's reference count. However,
the corresponding va_macro_remove() function does not call clk_put()
to release this reference, resulting in a resource leak.

Add clk_put() call in va_macro_remove() to properly release the fsgen
clock reference.

Fixes: 908e6b1df26e ("ASoC: codecs: lpass-va-macro: Add support to VA Macro")
Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>
---
 sound/soc/codecs/lpass-va-macro.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-macro.c
index a49551f3fb29..440d0f54aa33 100644
--- a/sound/soc/codecs/lpass-va-macro.c
+++ b/sound/soc/codecs/lpass-va-macro.c
@@ -1663,6 +1663,7 @@ static void va_macro_remove(struct platform_device *pdev)
 {
 	struct va_macro *va = dev_get_drvdata(&pdev->dev);
 
+	clk_put(va->fsgen);
 	if (va->has_npl_clk)
 		clk_disable_unprepare(va->npl);
 
-- 
2.50.1.windows.1