linux-kernel - Re: [PATCH v2 00/12] nova-core: Complete GSP boot and begin RPC communication

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f76f61df-8412-461f-8d85-b9ba0fa92df0@nvidia.com>
Date: Mon, 3 Nov 2025 14:35:01 -0500
From: Joel Fernandes <joelagnelf@...dia.com>
To: Timur Tabi <ttabi@...dia.com>,
 "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
 "dakr@...nel.org" <dakr@...nel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 Alexandre Courbot <acourbot@...dia.com>,
 "rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>
Cc: "joel@...lfernandes.org" <joel@...lfernandes.org>,
 "lossin@...nel.org" <lossin@...nel.org>, "ojeda@...nel.org"
 <ojeda@...nel.org>, "boqun.feng@...il.com" <boqun.feng@...il.com>,
 "a.hindborg@...nel.org" <a.hindborg@...nel.org>,
 "simona@...ll.ch" <simona@...ll.ch>, "tmgross@...ch.edu"
 <tmgross@...ch.edu>, "alex.gaynor@...il.com" <alex.gaynor@...il.com>,
 "tzimmermann@...e.de" <tzimmermann@...e.de>,
 "mripard@...nel.org" <mripard@...nel.org>,
 "maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
 "nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
 John Hubbard <jhubbard@...dia.com>,
 "bjorn3_gh@...tonmail.com" <bjorn3_gh@...tonmail.com>,
 "airlied@...il.com" <airlied@...il.com>,
 "aliceryhl@...gle.com" <aliceryhl@...gle.com>,
 "gary@...yguo.net" <gary@...yguo.net>, Alistair Popple <apopple@...dia.com>
Subject: Re: [PATCH v2 00/12] nova-core: Complete GSP boot and begin RPC
 communication



On 11/3/2025 2:12 PM, Timur Tabi wrote:
> On Sun, 2025-11-02 at 18:59 -0500, Joel Fernandes wrote:
>> Hello!
>> These patches a refresh of the series adding support for final stages of the
>> GSP boot process where a sequencer which inteprets firmware instructions needs
>> to run to boot the GSP processor, followed by waiting for an INIT_DONE message
>> from the GSP.
>>
>> The patches are based on Alex's github branch which have several prerequisites:
>> Repo: https://github.com/Gnurou/linux.git Branch: b4/gsp_boot
>>
>> I also dropped several patches (mainly from John that have already been
>> applied).  Tested on Ampere GA102. We also need the "gpu: nova-core: Add
>> get_gsp_info() command" patch which I dropped since it needs to be reworked,
>> and it is not needed for GSP boot on Ampere (but John mentioned it is needed
>> for Blackwell so we could include it in the Blackwell series or I can try to
>> include it in this series if I'm respinning).
> 
> I applied your patches on top of Alex's tree, and when I boot on a GA102 I get this:
> 
> [  376.316679] NovaCore 0000:65:00.0: NVIDIA (Chipset: GA102, Architecture: Ampere, Revision: a.1)
> [  377.188060] NovaCore 0000:65:00.0: GSP RPC: send: seq# 0, function=Ok(GspSetSystemInfo),
> length=0x3f0
> [  377.188070] NovaCore 0000:65:00.0: GSP RPC: send: seq# 1, function=Ok(SetRegistry), length=0xc5
> [  378.315960] NovaCore 0000:65:00.0: GSP RPC: receive: seq# 0, function=NOCAT, length=0x50c
> [  378.319875] NovaCore 0000:65:00.0: probe with driver NovaCore failed with error -34
> 
> Are you sure there are no other patches?  The RPC patches can't depend on INIT_DONE being the first
> response.  Getting a NOCAT RPC first is not uncommon.

It works on my end. Do you have "the wait for init done" patch (the 12th patch?)
You can also boot my tree which has all the patches, i.e. this series + Alex's
b4/gsp_boot branch:
https://web.git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git/log/?h=nova-seq-init-done-submitted-v2

[    4.672205] virtme-ng-init: initialization done
[   25.745799] NovaCore 0000:00:07.0: NVIDIA (Chipset: GA102, Architecture:
Ampere, Revision: a.1)
[   26.364343] NovaCore 0000:00:07.0: GSP RPC: send: seq# 0,
function=Ok(GspSetSystemInfo), length=0x3f0
[   26.364634] NovaCore 0000:00:07.0: GSP RPC: send: seq# 1,
function=Ok(SetRegistry), length=0xc5
[   27.561186] NovaCore 0000:00:07.0: GSP RPC: receive: seq# 0,
function=RUN_CPU_SEQUENCER, length=0x18e8
[   27.635180] NovaCore 0000:00:07.0: GSP RPC: receive: seq# 0, function=NOCAT,
length=0x50c
[   27.635529] NovaCore 0000:00:07.0: GSP RPC: receive: seq# 0,
function=LIBOS_PRINT, length=0x68
[   27.635795] NovaCore 0000:00:07.0: GSP RPC: receive: seq# 0,
function=LIBOS_PRINT, length=0x70
[   27.790175] NovaCore 0000:00:07.0: GSP RPC: receive: seq# 0,
function=INIT_DONE, length=0x50