lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID:
 <VI1PR02MB39524B46A1A8D8E49E197F5D9CC7A@VI1PR02MB3952.eurprd02.prod.outlook.com>
Date: Mon, 3 Nov 2025 19:43:30 +0000
From: David Binderman <dcb314@...mail.com>
To: "harry.wentland@....com" <harry.wentland@....com>, "sunpeng.li@....com"
	<sunpeng.li@....com>, "siqueira@...lia.com" <siqueira@...lia.com>,
	"alexander.deucher@....com" <alexander.deucher@....com>,
	"christian.koenig@....com" <christian.koenig@....com>, "airlied@...il.com"
	<airlied@...il.com>, "simona@...ll.ch" <simona@...ll.ch>,
	"amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, LKML
	<linux-kernel@...r.kernel.org>
Subject:
 linux-6.18-rc4/drivers/gpu/drm/amd/display/dc/dpp/dcn30/dcn30_dpp.c:96:45:
 style: Same expression on both sides of '/'

Hello there,

Static analyser cppcheck says:

linux-6.18-rc4/drivers/gpu/drm/amd/display/dc/dpp/dcn30/dcn30_dpp.c:96:45: style: Same expression on both sides of '/' because 'sizeof(dpp_input_csc_matrix)' and 'sizeof(struct dpp_input_csc_matrix)' represent the same value. [duplicateExpression]

Source code is

    int arr_size = sizeof(dpp_input_csc_matrix)/sizeof(struct dpp_input_csc_matrix);

Isn't this just a fancy way of setting arr_size to 1 ?
Suggest code rework.

Regards

David Binderman

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ