linux-kernel - Re: [PATCH] Fix a drop_nlink warning in minix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202511031229.rqpKLU46-lkp@intel.com>
Date: Mon, 3 Nov 2025 12:42:37 +0800
From: kernel test robot <lkp@...el.com>
To: Jori Koolstra <jkoolstra@...all.nl>,
	Christian Brauner <brauner@...nel.org>,
	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
	Taotao Chen <chentaotao@...iglobal.com>,
	Jeff Layton <jlayton@...nel.org>, Jan Kara <jack@...e.cz>,
	NeilBrown <neil@...wn.name>
Cc: oe-kbuild-all@...ts.linux.dev, jkoolstra@...all.nl,
	linux-kernel@...r.kernel.org,
	syzbot+a65e824272c5f741247d@...kaller.appspotmail.com
Subject: Re: [PATCH] Fix a drop_nlink warning in minix_rename

Hi Jori,

kernel test robot noticed the following build errors:

[auto build test ERROR on brauner-vfs/vfs.all]
[also build test ERROR on linus/master v6.18-rc4 next-20251031]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jori-Koolstra/Fix-a-drop_nlink-warning-in-minix_rename/20251103-022646
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link:    https://lore.kernel.org/r/20251102182532.2442670-1-jkoolstra%40xs4all.nl
patch subject: [PATCH] Fix a drop_nlink warning in minix_rename
config: arc-randconfig-r073-20251103 (https://download.01.org/0day-ci/archive/20251103/202511031229.rqpKLU46-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251103/202511031229.rqpKLU46-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511031229.rqpKLU46-lkp@intel.com/

All errors (new ones prefixed by >>):

   fs/minix/namei.c: In function 'minix_unlink':
>> fs/minix/namei.c:151:11: error: 'EFSCORRUPTED' undeclared (first use in this function); did you mean 'FS_NRSUPER'?
      return -EFSCORRUPTED;
              ^~~~~~~~~~~~
              FS_NRSUPER
   fs/minix/namei.c:151:11: note: each undeclared identifier is reported only once for each function it appears in
   fs/minix/namei.c: In function 'minix_rename':
   fs/minix/namei.c:217:10: error: 'EFSCORRUPTED' undeclared (first use in this function); did you mean 'FS_NRSUPER'?
      err = -EFSCORRUPTED;
             ^~~~~~~~~~~~
             FS_NRSUPER


vim +151 fs/minix/namei.c

   140	
   141	static int minix_unlink(struct inode * dir, struct dentry *dentry)
   142	{
   143		struct inode * inode = d_inode(dentry);
   144		struct folio *folio;
   145		struct minix_dir_entry * de;
   146		int err;
   147	
   148		if (inode->i_nlink < 1) {
   149			printk(KERN_CRIT "minix-fs error: inode (ino: %ld) "
   150			       "has corrupted nlink", inode->i_ino);
 > 151			return -EFSCORRUPTED;
   152		}
   153	
   154		de = minix_find_entry(dentry, &folio);
   155		if (!de)
   156			return -ENOENT;
   157		err = minix_delete_entry(de, folio);
   158		folio_release_kmap(folio, de);
   159	
   160		if (err)
   161			return err;
   162		inode_set_ctime_to_ts(inode, inode_get_ctime(dir));
   163		inode_dec_link_count(inode);
   164		return 0;
   165	}
   166	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki