linux-kernel - Re: [PATCH] i3c: dw: Add apb reset support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251103-deviancy-gurgling-0b37c8637a8c@spud>
Date: Mon, 3 Nov 2025 22:09:30 +0000
From: Conor Dooley <conor@...nel.org>
To: Frank Li <Frank.li@....com>
Cc: Jisheng Zhang <jszhang@...nel.org>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	linux-i3c@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i3c: dw: Add apb reset support

On Mon, Nov 03, 2025 at 10:44:04AM -0500, Frank Li wrote:
> On Sun, Nov 02, 2025 at 06:02:37PM +0800, Jisheng Zhang wrote:
> > Add support of apb reset which is to reset the APB interface.
> >
> > Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> > ---
> >  drivers/i3c/master/dw-i3c-master.c | 9 +++++++++
> >  drivers/i3c/master/dw-i3c-master.h | 1 +
> >  2 files changed, 10 insertions(+)
> >
> > diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> > index 9ceedf09c3b6..ca2863d2b2b7 100644
> > --- a/drivers/i3c/master/dw-i3c-master.c
> > +++ b/drivers/i3c/master/dw-i3c-master.c
> > @@ -1558,7 +1558,13 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
> >  	if (IS_ERR(master->core_rst))
> >  		return PTR_ERR(master->core_rst);
> >
> > +	master->apb_rst = devm_reset_control_get_optional_exclusive(&pdev->dev,
> > +								    "apb_rst");
> 
> Does binding already add "app_rst"?  The name "app" should be enough.

The binding defines no resets at all, so there's a missing patch here.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)