linux-kernel - Re: [PATCH v3 1/1] firmware: stratix10-svc: fix bug in saving controller data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4343e9cc-9e22-46bf-b78b-7b934d888f28@altera.com>
Date: Mon, 3 Nov 2025 23:10:59 +0000
From: "Romli, Khairul Anuar" <khairul.anuar.romli@...era.com>
To: Dinh Nguyen <dinguyen@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "Ang, Tien Sung" <tien.sung.ang@...era.com>
Subject: Re: [PATCH v3 1/1] firmware: stratix10-svc: fix bug in saving
 controller data

On 3/11/2025 8:14 pm, Dinh Nguyen wrote:
> 
> 
> On 11/2/25 17:21, Khairul Anuar Romli wrote:
>> Fix the incorrect usage of platform_set_drvdata and dev_set_drvdata. They
>> both are of the same data and overrides each other. This resulted in the
>> rmmod of the svc driver to fail and throw a kernel panic for kthread_stop
>> and fifo free.
>>
>> Fixes: b5dc75c915cda ("firmware: stratix10-svc: extend svc to support 
>> new RSU features")
> 
> Trimming this to 12 characters SHA. I know that documentation says at 
> least 12, and not exactly 12, but the normal procedure is to use exactly 
> 12.
> 
> Applied!
> 
> Thanks,
> Dinh

Noted. Thanks for helping out to trim it to 12 chars.

Best Regards,
Khairul